Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Annotation] Circle radius is modified when saving the annotation #9937

Closed
dsuren1 opened this issue Jan 31, 2024 · 0 comments · Fixed by #9938
Closed

[Annotation] Circle radius is modified when saving the annotation #9937

dsuren1 opened this issue Jan 31, 2024 · 0 comments · Fixed by #9938
Assignees
@dsuren1 @ElenaGallo
Labels
Accepted bug C169-Rennes-Métropole-2023-GeOrchestra4 Phase 4

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Jan 31, 2024 •
edited
Loading

Description
[Annotation] Circle radius is modified when saving the annotation (Happens only in stable 2023.02.xx)

To Reproduce
Steps to reproduce the behavior:

  • Set new.json to EPSG:3857
  • Open a new map
  • Add a circle annotation and save
  • Upon saving the circle radius changes

Expected behavior
conservation of the circle size

Investigation
This issue is caused by transformPolygonToCircle when the circle is geodesic

Ref:
georchestra/mapstore2-georchestra#681
@dsuren1 dsuren1 self-assigned this Jan 31, 2024
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Jan 31, 2024
@dsuren1
geosolutions-it#9937 - Fix: Circle radius is modified when saving the…
b3d50d4 
… annotation
@dsuren1 dsuren1 mentioned this issue Jan 31, 2024
Merged
5 tasks
@dsuren1 dsuren1 linked a pull request Jan 31, 2024 that will close this issue
#9937 - Fix: Circle radius is modified when saving the annotation #9938
Merged
5 tasks
allyoucanmap pushed a commit that referenced this issue Jan 31, 2024
@dsuren1
#9937 - Fix: Circle radius is modified when saving the annotation (#9938
1dfbf08 
)
@tdipisa tdipisa added this to the 2024.01.00 milestone Jan 31, 2024
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 31, 2024
@tdipisa tdipisa removed this from the 2024.01.00 milestone Jan 31, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 31, 2024
@ElenaGallo ElenaGallo self-assigned this Feb 1, 2024
@tdipisa tdipisa closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuren1 dsuren1

@ElenaGallo ElenaGallo

Labels
Accepted bug C169-Rennes-Métropole-2023-GeOrchestra4 Phase 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#9937 - Fix: Circle radius is modified when saving the annotation dsuren1/MapStore2
3 participants
@tdipisa @dsuren1 @ElenaGallo