-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fast processing for RINEX 3 #85
base: main
Are you sure you want to change the base?
Conversation
Now sets flag correctly
Thank you this has been a long-requested feature! |
.Z compressed files can also have Hatanaka compression
fixed critical indexing mistake in fast obs3
I tested this today and it works well. I highly recommend to merge this! This will close: #23 |
Fixed rare issue with duplicate times
Thanks, I had to fix other bugs first related to xarray changes. Thanks for your changes and endorsement! |
limited calls to genfromtxt for 2x speed
Looks like the line [186] is incorrect usually it works - if you have sats [g01,g02,g03] and this sats appears in same order, you will get correct indexes [0,1,2] |
I think you are right, in the first version of the code I had made an indexing mistake. I had to re-write the fast processing again since it wasn't fast enough, it is a lot more elegant now. I don't think the line you are referring to exists in the code anymore, though. Please let me know if the problem still exists! |
Oh, this definitely possible. I am not a big specialist in git so that is really possible that I took some outdated version. |
Genfromtextfix
added support for rinex v4 observation files
Thanks @breid-phys, this is great. @scivision is there a plan to merge this in? |
The RINEX 3 code was re-written following the general idea behind the fast RINEX 2 code, loading all of the values into a numpy array before converting to xarray at the end.
The new code is significantly faster than before, and passes all of the automated tests. If the 'fast' flag is false, it should use the same technique as before.
All of the changes should be within rinexobs3().