Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache each range request #41

Merged
merged 4 commits into from
Jun 6, 2020
Merged

cache each range request #41

merged 4 commits into from
Jun 6, 2020

Conversation

geospatial-jeff
Copy link
Owner

@geospatial-jeff geospatial-jeff commented Jun 6, 2020

  • Caches each range request rather than each internal block.
    • This has the upside of caching the file header as well as each block.
    • The downside is the bytes themselves are cached instead of the decompressed array, so repeated calls to the same tile require decompressing multiple times.
  • There is still work to be done to ensure we aren't caching the same byte multiple times in situations where a single byte is part of multiple ranges.
    Ref Caching merged range requests #30

@codecov-commenter
Copy link

Codecov Report

Merging #41 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   94.94%   94.96%   +0.02%     
==========================================
  Files          10       10              
  Lines         712      715       +3     
==========================================
+ Hits          676      679       +3     
  Misses         36       36              
Impacted Files Coverage Δ
aiocogeo/cog.py 96.63% <ø> (-0.22%) ⬇️
aiocogeo/config.py 100.00% <100.00%> (ø)
aiocogeo/filesystems.py 92.56% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1043488...7e8a0bc. Read the comment docs.

@geospatial-jeff geospatial-jeff merged commit 963b6b9 into master Jun 6, 2020
@geospatial-jeff geospatial-jeff deleted the lower-level-cache branch June 6, 2020 19:43
@geospatial-jeff geospatial-jeff mentioned this pull request Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants