Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphicFill write support for polygon symbolizer (WIP) #244

Closed
wants to merge 1 commit into from

Conversation

rdewit
Copy link

@rdewit rdewit commented Feb 25, 2021

Description

The PR adds support for creating OL graphic fill styles from polygon symbolizer. Only types of Icon and Mark are supported.

It uses the newish renderer function for OL styles, which has one unfortunate drawback: it breaks the zIndex ordering and always draws the symbolizer on top of other ones.

geostyler-polygon-graphic-fill-example

Related issues or pull requests

This could solve #240 and #228

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@rdewit
Copy link
Author

rdewit commented Feb 25, 2021

The PR is currently in draft mode as it's not complete (no tests yet) and may need further discussion about the implementation choices that I've made.

I tried to make the rendering as efficient as possible and I'd love to get feedback on how to improve this further, including how to better deal with scaled Icons.

@rdewit rdewit changed the title Add graphicFill read support for polygon symbolizer (WIP) Add graphicFill write support for polygon symbolizer (WIP) Feb 25, 2021
@jansule jansule mentioned this pull request Sep 3, 2021
17 tasks
@rdewit
Copy link
Author

rdewit commented Oct 8, 2021

Thanks @jansule for getting GraphicFill support in (#388)! I'll close this PR.

@rdewit rdewit closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant