Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to esm build #803

Closed
wants to merge 1 commit into from
Closed

feat: switch to esm build #803

wants to merge 1 commit into from

Conversation

hwbllmnn
Copy link
Contributor

BREAKING CHANGE: you may need to adjust your imports as some of the paths have been changed

Description

See title.

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@geostyler/devs Please review.

@hwbllmnn
feat: switch to esm build
71502fb 
BREAKING CHANGE: you may need to adjust your imports as some
of the paths have been changed
jansule
jansule approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@jansule jansule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@hwbllmnn
Copy link
Contributor Author

Closing in favour of #804

@hwbllmnn hwbllmnn closed this Jun 19, 2024
@hwbllmnn hwbllmnn deleted the use-esm-build branch June 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansule jansule jansule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwbllmnn @jansule