Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance unsupported properties test #827

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Enhance unsupported properties test #827

merged 4 commits into from
Dec 2, 2024

Conversation

KaiVolland
Copy link
Contributor

@KaiVolland KaiVolland commented Nov 27, 2024 •
edited
Loading

Description

This MR enhances the test for unsupported properties.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@KaiVolland KaiVolland mentioned this pull request Nov 27, 2024
Open
jansule
jansule reviewed Nov 27, 2024
View reviewed changes
src/OlStyleParser.ts Outdated Show resolved Hide resolved
jansule
jansule approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jansule jansule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@KaiVolland KaiVolland merged commit 37bddd4 into main Dec 2, 2024
5 checks passed
@KaiVolland KaiVolland deleted the enhance-test branch December 2, 2024 08:30
@jansule
Copy link
Contributor

jansule commented Dec 2, 2024

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansule jansule jansule approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiVolland @jansule