Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore fill color property when style = no #365

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Ignore fill color property when style = no #365

merged 6 commits into from
Sep 13, 2022

Conversation

slafayIGN
Copy link
Collaborator

@slafayIGN slafayIGN commented Sep 8, 2022

In a SimpleFill layer section, if the style property is set to no, the fill color is ignored.
The color is kept if the style property is set to solid.

Example:

<prop v="no" k="style"/>
<prop v="128,128,128,255" k="color"/>

=> color property is ignored.

A read test has been added.


Related issue : #336

Copy link
Contributor

@jansule jansule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks!

@jansule jansule merged commit ae52033 into geostyler:master Sep 13, 2022
@slafayIGN slafayIGN deleted the style-fill-color branch September 30, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants