Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the secret from my.tado.com automatically #8

Closed
wants to merge 2 commits into from

Conversation

colinleroy
Copy link

Hi,

Hope this helps, and thanks for the lib :)

@rhuijben
Copy link

This code didn't work directly on my Python 3.7 setup. I had to explicitly get the .text() from the request before I could parse the lines.

@germainlefebvre4
Copy link
Owner

germainlefebvre4 commented Nov 14, 2020 via email

@rhuijben
Copy link

Json encoding usually works with response.json().
I will take a look as soon as possible

This output is not valid json, unless you skip the first and last few characters.

Bert

@germainlefebvre4
Copy link
Owner

I am reworking the job to parse the endpoint as a text block and not as a dict. Easier, mucher faster, et errors handled.
I get you guys in touch about the working in progress branch.

@germainlefebvre4
Copy link
Owner

A first version has been pushed for CLI on branch fix/client-secret #16.

@colinleroy
Copy link
Author

A first version has been pushed for CLI on branch fix/client-secret #16.

Seems cool, thanks!

@germainlefebvre4
Copy link
Owner

I close this PR and switch to the #16 one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants