Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo when min support moves to python 3.8 #68

Closed
6 tasks done
maread99 opened this issue Jul 27, 2021 · 1 comment
Closed
6 tasks done

todo when min support moves to python 3.8 #68

maread99 opened this issue Jul 27, 2021 · 1 comment
Labels
TODO Todo list for feature or release

Comments

@maread99
Copy link
Collaborator

maread99 commented Jul 27, 2021

  • lose memoize.py \ @lazyval in favour of @functools.cached_property
  • on Answers and ExchangeCalendar classes consolidate properties returning functions decorated @functools.lru_cache with simple properties decorated with @functools.cached_property
  • use Literal to annotate selection of string values, to include at least:
    • direction parameter of ExchangeCalendar, minute_to_session_label and date_to_session_label methods as Literal["next", "previous", "none"]
    • side parameter of ExchangeCalendar, test_exchange_calendar.py and calendar_helper.py methods as Literal["left", "right", "both", "neither"]
    • column parameter of Answers._get_sessions_with_times_different_to_a_contiguous_session as Literal["opens", "closes", "break_starts", "break_ends"]
@maread99 maread99 added the TODO Todo list for feature or release label Jul 27, 2021
@maread99 maread99 mentioned this issue Oct 5, 2021
49 tasks
@maread99
Copy link
Collaborator Author

Incorporated in #187 for v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO Todo list for feature or release
Projects
None yet
Development

No branches or pull requests

1 participant