forked from quantopian/trading_calendars
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
todo for release 4.0 #61
Labels
TODO
Todo list for feature or release
Comments
I'd add
My preference is probably some markdown backed sphinx system on github pages. |
This was referenced Sep 14, 2021
This was referenced Jan 10, 2022
Merged
This was referenced May 26, 2022
This was referenced Jun 3, 2022
maread99
added a commit
that referenced
this issue
Jun 6, 2022
Renames following `ExchangeCalendar.schedule` columns: - 'market_open' renamed 'open' - 'market_close' renamed 'close' Renames parameters of following `ExchangeCalendar` methods (as #61): - `session_open` - `session_close` - `session_break_start` - `session_break_end` - `sessions_in_range` - `is_session` - `is_open_on_minute` - `previous_open` - `pervious_close` - `next_open` - `next_close` - `previous_minute` - `next_minute`
maread99
added a commit
that referenced
this issue
Jun 7, 2022
Renames following `ExchangeCalendar.schedule` columns: - 'market_open' renamed 'open' - 'market_close' renamed 'close' Renames parameters of following `ExchangeCalendar` methods (as #61): - `session_open` - `session_close` - `session_break_start` - `session_break_end` - `sessions_in_range` - `is_session` - `is_open_on_minute` - `previous_open` - `pervious_close` - `next_open` - `next_close` - `previous_minute` - `next_minute`
This was referenced Jun 8, 2022
maread99
added a commit
that referenced
this issue
Jun 22, 2022
Renames following `ExchangeCalendar.schedule` columns: - 'market_open' renamed 'open' - 'market_close' renamed 'close' Renames parameters of following `ExchangeCalendar` methods (as #61): - `session_open` - `session_close` - `session_break_start` - `session_break_end` - `sessions_in_range` - `is_session` - `is_open_on_minute` - `previous_open` - `pervious_close` - `next_open` - `next_close` - `previous_minute` - `next_minute`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've opened this to consolidate any breaking changes that would need to be delayed until / incorporated in any release 4.0.
session_label
parameter ofExchangeCalendar
methods to be renamedsession
(which is given context fromSession
type and checks imposed by subsequent parsing). Methods requiring change include:previous_session_label
(changed when renamed, Renaming of some ExchangeCalendar methods #85)next_session_label
(changed when renamed, Renaming of some ExchangeCalendar methods #85)session_open
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)session_close
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)session_break_start
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)session_break_end
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)open_and_close_for_session
(changed when renamed, Renaming of some ExchangeCalendar methods #85)break_start_and_end_for_session
(changed when renamed, Renaming of some ExchangeCalendar methods #85)minutes_for_session
(changed when renamed, Renaming of some ExchangeCalendar methods #85)sessions_window
(done v4 dev: revises*window
,bound*
,default*
and prev/next session/minute methods. #184)For following methods,
start_session_label
/end_session_label
parameters to be renamedstart
/end
sessions_in_range
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)minutes_for_sessions_in_range
(changed when renamed, Renaming of some ExchangeCalendar methods #85)session_opens_in_range
(changed when renamed, Renaming of some ExchangeCalendar methods #85)session_closes_in_range
(changed when renamed, Renaming of some ExchangeCalendar methods #85)session_distance
(changed when renamed, Renaming of some ExchangeCalendar methods #85)For following methods,
start_session
/end_session
parameters to be renamedstart
/end
minutes_count_for_sessions_in_range
(changed when renamed, Renaming of some ExchangeCalendar methods #85)For following methods,
start_minute
/end_minute
parameters to be renamedstart
/end
minutes_in_range
(done v4 dev: Update doc and tutorials for 4.0 #194)For following methods,
dt
to be renameddate
:is_session
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)dt
parameter ofExchangeCalendar
methods to be renamedminute
(given context from 'Minute' type and checks imposed by subsequent parsing). Methods requring change include:minute_to_session_label
(changed when renamed, Renaming of some ExchangeCalendar methods #85)is_open_on_minute
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)previous_open
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)previous_close
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)next_open
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)next_close
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)previous_minute
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)next_minute
(done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)For following methods,
start_dt
to be renamedminute
:minutes_window
(done v4 dev: revises*window
,bound*
,default*
and prev/next session/minute methods. #184)index
parameter ofminute_index_to_session_labels
to be renamedminutes
(changed when renamed, Renaming of some ExchangeCalendar methods #85)ExchangeCalendar.schedule
columns: (done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)market_open
toopen
market_close
toclose
ExchangeCalendar
methods deprecated ahead of release 3.4 - all were renamed (Renaming of some ExchangeCalendar methods #85) save for the fourexecution_*
methods: (done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)execution_minutes_for_session
execution_minutes_for_sessions_in_range
execution_time_from_open
execution_time_from_close
previous_session_label
next_session_label
date_to_session_label
minute_to_session_label
open_and_close_for_session
break_start_and_end_for_session
minutes_for_session
session_opens_in_range
session_closes_in_range
minutes_for_sessions_in_range
minutes_count_for_sessions_in_range
session_distance
minute_index_to_session_labels
all_sessions
all_minutes
all_minutes_nanos
first_trading_minute
last_trading_minute
first_trading_session
last_trading_session
has_breaks
market_opens_nanos
market_closes_nanos
market_break_starts_nanos
market_break_ends_nanos
sessions_opens
andsessions_closes
now that, with schedule times changing to UTC timestamps,cal.sessions_opens(start, end)
will return the same ascal.opens[start:end]
(there should be only one obvious way to do something...). (done v4 dev: Rename parameters, deprecate methods and remove deprecated methods #186)side
default for all calendars to "left" (from "right" for 24 hour calendars and from "both" for others). See Set default calendarside
to "left" from v4 #181. (done v4 dev: Change defaultside
to "left" and post v4 linting #191)ExchangeCalendar
methodssessions_window
andminutes_window
so thatcount
parameter matches the length of the return (the length of which is currently count + 1). i.e. just addcount -= 1
as methods' first line and raiseValueError
ifcount
received as 0. (done v4 dev: revises*window
,bound*
,default*
and prev/next session/minute methods. #184)Consider changing behaviour of. Considered, left as is.is_open_on_minute
to distinguish it fromis_trading_minute
. Proposed that theignore_breaks
option be removed and the method act as ifignore_breaks
were True, i.e.is_open_on_minute
would act asis_trading_minute
albeit treating any break minutes as open. Method documentation should make clear that market is considered open on break minutesExchangeCalendar
propertiesbound_start
andbound_end
to class attributes (they are class-specific, not instance-specific) anddefault_start
anddefault_end
to class methodswith intention of changing to class properties when min python version moves to 3.9 (as noted to todo when min support moves to python 3.9 #98 for. 22/06/06 - done v4 dev: revisesvalid_sides
anddefault_side
)*window
,bound*
,default*
and prev/next session/minute methods. #184, made all class methods.errors.RequestedSessionOutOfBounds
when request session/minute falls beyond calendar bound: (done v4 dev: revises*window
,bound*
,default*
and prev/next session/minute methods. #184)next_session
(remove fromminute_to_future_session
method the current_session == last_session check and raise.)previous_session
(remove fromminute_to_past_session
method the current_session == first_session check and raise.)next_minute
previous_minute
ExchangeCalendar.trading_index
, orcalendar_helpers._TradingIndex
, to: (done v4 dev: fix warnings and update trading index #180)start
andend
parameters to be passed as times (as opposed to only dates).force
option to define bothforce_close
andforce_break_close
.Add note to top of all tutorials that best viewed in Jupyter Lab / Jupyter Notebook or via nbviewer.start
andend
calendar options to README Quick Start and an appropriate tutorial. (done v4 dev: Update doc and tutorials for 4.0 #194)Desired enhancements that are non-breaking:
The text was updated successfully, but these errors were encountered: