Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dockerfile generation part is kind of ugly #117

Closed
chainsawriot opened this issue Mar 20, 2023 · 0 comments
Closed

The Dockerfile generation part is kind of ugly #117

chainsawriot opened this issue Mar 20, 2023 · 0 comments

Comments

@chainsawriot
Copy link
Collaborator

https://github.com/chainsawriot/rang/blob/de0f640bbfc253deb6947c30ebc56da863d0b368/R/installation.R#L117-L168

The index-based injection is kind of ugly (and risky). But the containerit way of OOP it is kind of overkill.

In general, there are five parts in a Dockerfile.

  1. FROM stuff (+ ADD)
  2. Unchanged Chores of setting up timezone (e.g. ENV TZ UTC)
  3. COPY statements where rang.R always gets copied, cache and compile_r.sh optional
  4. RUN statements (either 1) just run rang, 2) just run compile_r, or mkdir lib and then 1 or 2)
  5. CMD (All CMD ["R"] except rstudio)
chainsawriot added a commit that referenced this issue Mar 20, 2023
Refactor dockerfile generation code #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant