-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose convert_edgelist (#56) #74
Conversation
@schochastics If you prefer el <- do.call("rbind",lapply(x$ranglets,convert_edgelist)) can be replaced by el <- vctrs::vec_rbind(lapply(x$ranglets,convert_edgelist)) now, probably slightly faster and more robust. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## v0.2 #74 +/- ##
==========================================
+ Coverage 92.51% 93.49% +0.98%
==========================================
Files 5 6 +1
Lines 641 646 +5
==========================================
+ Hits 593 604 +11
+ Misses 48 42 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ah nice will do that |
hmm that didnt work |
@schochastics Sorry, I checked and it doesn't work as I said. Please revert. |
@chainsawriot done. Happy that my faithful companion |
Well ### but need to import the triple bang
vctrs::vec_rbind(!!!(lapply(graph$ranglets, convert_edgelist))) Rather than being smart like this, I rather opt for being familiar. Please keep the |
haha I was actually wondering if a series of "!" could solve this issue. Well, TIL |
Turned it into a generic function that works with rang and ranglet objects.