Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce dependencies (#94) #95

Merged
merged 2 commits into from
Feb 26, 2023
Merged

reduce dependencies (#94) #95

merged 2 commits into from
Feb 26, 2023

Conversation

schochastics
Copy link
Member

@schochastics schochastics commented Feb 26, 2023

  • gh
  • anytime

gh::gh is now .gh

@schochastics
Copy link
Member Author

@chainsawriot do you want to get rid of jsonlite completely or just the one jsonlite::read_json() (which is gone now)?

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #95 (a2c8a40) into v0.2 (3d1b46e) will decrease coverage by 0.21%.
The diff coverage is 90.32%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             v0.2      #95      +/-   ##
==========================================
- Coverage   96.65%   96.45%   -0.21%     
==========================================
  Files           6        6              
  Lines         718      733      +15     
==========================================
+ Hits          694      707      +13     
- Misses         24       26       +2     
Impacted Files Coverage Δ
R/resolve.R 95.77% <90.00%> (-0.44%) ⬇️
R/memo_misc.R 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chainsawriot
Copy link
Collaborator

chainsawriot commented Feb 26, 2023

@schochastics I think we can keep jsonlite (and other instances of jsonlite) for now. Until we want to create those VCR tests.

https://github.com/chainsawriot/rang/blob/3d1b46eab460d5f28d93205c25741023dcda2eec/R/as_pkgrefs.R#L104

This needs to use jsonlite for offline reading.

@schochastics
Copy link
Member Author

we can always go back to that simple json parser that was removed in 8167770 when we you want to switch to vcr

@schochastics schochastics marked this pull request as ready for review February 26, 2023 20:35
@schochastics
Copy link
Member Author

ok gh and anytime are both gone. Could be merged if no other suggestions from you

@chainsawriot
Copy link
Collaborator

The missing codecov lines are not very important (we need to use Github Secret to get rid of it). I will merge it now. Thank you very much!

@chainsawriot chainsawriot merged commit 009a4dc into gesistsa:v0.2 Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants