Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set snapshot date depending on pkgs (#53,#55) #97

Merged
merged 4 commits into from
Feb 27, 2023
Merged

set snapshot date depending on pkgs (#53,#55) #97

merged 4 commits into from
Feb 27, 2023

Conversation

schochastics
Copy link
Member

@chainsawriot please check if you are ok with the logic of .extract_date()

@chainsawriot
Copy link
Collaborator

@schochastics "../testdata/bioc_renv.RDS" needs update.

@schochastics
Copy link
Member Author

Yeah shouldnt have done this 5 minutes before dinner. Will fix later

@chainsawriot
Copy link
Collaborator

chainsawriot commented Feb 27, 2023

How about this: just use the original big renv.lock to test the parsing. And have a tiny renv.lock (with maybe 3 packages, one CRAN, one bioc, one GH) to do the integration test?

You can put different renv.lock files into directories.

@schochastics
Copy link
Member Author

saw your comment to late but thats a good idea. Will implement that quickly

@schochastics
Copy link
Member Author

@chainsawriot when these checks pass, then it is done

@codecov-commenter
Copy link

Codecov Report

Merging #97 (2cc6a00) into v0.2 (17edbfc) will decrease coverage by 0.23%.
The diff coverage is 82.35%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             v0.2      #97      +/-   ##
==========================================
- Coverage   96.50%   96.27%   -0.23%     
==========================================
  Files           6        6              
  Lines         743      752       +9     
==========================================
+ Hits          717      724       +7     
- Misses         26       28       +2     
Impacted Files Coverage Δ
R/resolve.R 95.29% <81.25%> (-0.48%) ⬇️
R/as_pkgrefs.R 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chainsawriot chainsawriot merged commit 5a31317 into gesistsa:v0.2 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants