Feat: Extend DurationDecoder to parse Duration so that it is able to …

…decode Durations written in ISO 8601 standardized string format like "PT42S"? Address issue #137
gestalt-config · Feb 16, 2024 · a48be2f · a48be2f
1 parent 84dfdb4
commit a48be2f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/gestalt-core/src/main/java/org/github/gestalt/config/decoder/DurationDecoder.java b/gestalt-core/src/main/java/org/github/gestalt/config/decoder/DurationDecoder.java
@@ -44,7 +44,11 @@ protected GResultOf<Duration> leafDecode(String path, ConfigNode node) {
                 results = GResultOf.errors(new ValidationError.ErrorDecodingException(path, node, name()));
             }
         } else {
-            results = GResultOf.errors(new ValidationError.DecodingNumberParsing(path, node, name()));
+            try {
+                results = GResultOf.result(Duration.parse(value));
+            } catch (Exception e) {
+                results = GResultOf.errors(new ValidationError.ErrorDecodingException(path, node, name()));
+            }
         }
         return results;
     }

diff --git a/gestalt-core/src/test/java/org/github/gestalt/config/decoder/DurationDecoderTest.java b/gestalt-core/src/test/java/org/github/gestalt/config/decoder/DurationDecoderTest.java
@@ -72,6 +72,18 @@ void decode() {
         Assertions.assertEquals(0, result.getErrors().size());
     }
 
+    @Test
+    void decodeISO8601() {
+        DurationDecoder decoder = new DurationDecoder();
+
+        GResultOf<Duration> result = decoder.decode("db.port", Tags.of(), new LeafNode("PT20S"),
+            TypeCapture.of(Long.class), new DecoderContext(decoderService, null));
+        Assertions.assertTrue(result.hasResults());
+        Assertions.assertFalse(result.hasErrors());
+        Assertions.assertEquals(Duration.ofSeconds(20), result.results());
+        Assertions.assertEquals(0, result.getErrors().size());
+    }
+
     @Test
     void decodeInvalidNode() {
         DurationDecoder decoder = new DurationDecoder();
@@ -83,8 +95,7 @@ void decodeInvalidNode() {
         Assertions.assertNull(result.results());
         Assertions.assertNotNull(result.getErrors());
         Assertions.assertEquals(ValidationLevel.ERROR, result.getErrors().get(0).level());
-        Assertions.assertEquals("Unable to parse a number on Path: db.port, from node: LeafNode{value='12s4'} " +
-                "attempting to decode Duration",
+        Assertions.assertEquals("Unable to decode a Duration on path: db.port, from node: LeafNode{value='12s4'}",
             result.getErrors().get(0).description());
     }