Propagate lexer from Gestalt Config to various locations #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders picking up the config.
feat: ModuleConfig for Map and properties Config Loader. test: add additional tests to show how to customize the sentence lexer. test: add documentation to the example test to better describe what it is doing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 90.01% 90.08% +0.06%
==========================================
Files 197 214 +17
Lines 5788 6009 +221
Branches 681 699 +18
==========================================
+ Hits 5210 5413 +203
- Misses 364 368 +4
- Partials 214 228 +14 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: pass the sentence lexer into the Gestalt Config, so it can be applied in all the loaders. Use the lexer to normalize the strings instead of all using a lowercase. #179
For most loaders add a new module configuration. Allows Env Vars among others to be more customizable. #151
Get the system properties from the system wrapper for easier debugging and testing.