Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tag Allows users to override how we find nodes to merge based on the tags. #195

Merged
merged 8 commits into from
May 28, 2024

Conversation

credmond-git
Copy link
Collaborator

Allows users to override how we find nodes to merge based on the tags. #194

Implement a Exact Match with Fallback to Default Strategy.
Make the ArrayNode and MapNode immutable.

…e tags.

Implement a Exact Match with Fallback to Default Strategy.
Make the ArrayNode and MapNode immutable.
Add extra methods to generate profile and environment tag.
…lder.

Add documentation on how to configure the ConfigNodeTagResolutionStrategy.
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 83.45324% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 90.56%. Comparing base (bf20bad) to head (6ab4ff0).

Files Patch % Lines
.../github/gestalt/config/node/ConfigNodeManager.java 79.27% 12 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   90.81%   90.56%   -0.25%     
==========================================
  Files         226      228       +2     
  Lines        6282     6349      +67     
  Branches      714      729      +15     
==========================================
+ Hits         5705     5750      +45     
- Misses        358      371      +13     
- Partials      219      228       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@credmond-git credmond-git merged commit 8366d1b into main May 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant