Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better support for defaults with CDI. #211

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

credmond-git
Copy link
Collaborator

No description provided.

Copy link

sonarqubecloud bot commented Sep 7, 2024

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (7ccfa72) to head (3c4a0d3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gestalt/config/cdi/GestaltConfigInjectionBean.java 0.00% 7 Missing and 1 partial ⚠️
.../gestalt/config/cdi/GestaltConfigProducerUtil.java 70.00% 1 Missing and 2 partials ⚠️
...n/java/org/github/gestalt/config/GestaltCache.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   91.04%   91.23%   +0.19%     
==========================================
  Files         250      250              
  Lines        6965     6980      +15     
  Branches      775      779       +4     
==========================================
+ Hits         6341     6368      +27     
+ Misses        384      370      -14     
- Partials      240      242       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@credmond-git credmond-git merged commit e23fc28 into main Sep 7, 2024
4 of 5 checks passed
@credmond-git credmond-git deleted the feat/cdi-default branch September 7, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant