Remove potentially expensive heap stats computation (#31074)

GitOrigin-RevId: 8974d55175d4d0896b5b6057371975b470630016
get-convex · Oct 31, 2024 · 80a6f8b · 80a6f8b
1 parent 6768818
commit 80a6f8b
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 51 deletions.
diff --git a/crates/application/src/application_function_runner/mod.rs b/crates/application/src/application_function_runner/mod.rs
@@ -117,7 +117,6 @@ use isolate::{
     HttpActionOutcome,
     IsolateClient,
     IsolateConfig,
-    IsolateHeapStats,
     JsonPackedValue,
     UdfOutcome,
     ValidatedPathAndArgs,
@@ -187,7 +186,6 @@ use usage_tracking::{
     FunctionUsageTracker,
 };
 use value::{
-    heap_size::HeapSize,
     id_v6::DeveloperDocumentId,
     identifier::Identifier,
     TableNamespace,
@@ -587,12 +585,6 @@ pub struct ApplicationFunctionRunner<RT: Runtime> {
     fetch_client: Arc<dyn FetchClient>,
 }
 
-impl<RT: Runtime> HeapSize for ApplicationFunctionRunner<RT> {
-    fn heap_size(&self) -> usize {
-        self.cache_manager.heap_size()
-    }
-}
-
 impl<RT: Runtime> ApplicationFunctionRunner<RT> {
     pub fn new(
         instance_name: String,
@@ -697,14 +689,6 @@ impl<RT: Runtime> ApplicationFunctionRunner<RT> {
         Ok(())
     }
 
-    pub fn database_heap_size(&self) -> IsolateHeapStats {
-        self.analyze_isolate.aggregate_heap_stats()
-    }
-
-    pub fn http_actions_heap_size(&self) -> IsolateHeapStats {
-        self.http_actions.aggregate_heap_stats()
-    }
-
     // Only used for running queries from REPLs.
     pub async fn run_query_without_caching(
         &self,

diff --git a/crates/application/src/cache/mod.rs b/crates/application/src/cache/mod.rs
@@ -103,12 +103,6 @@ pub struct CacheManager<RT: Runtime> {
     cache: Cache,
 }
 
-impl<RT: Runtime> HeapSize for CacheManager<RT> {
-    fn heap_size(&self) -> usize {
-        self.cache.heap_size()
-    }
-}
-
 #[derive(Clone, Eq, PartialEq, Hash)]
 pub struct CacheKey {
     path: PublicFunctionPath,
@@ -716,12 +710,6 @@ impl Cache {
     }
 }
 
-impl HeapSize for Cache {
-    fn heap_size(&self) -> usize {
-        self.inner.lock().size
-    }
-}
-
 impl Inner {
     // Remove only a `CacheEntry::Ready` from the cache, predicated on its
     // `executor_id` matching.

diff --git a/crates/application/src/function_log.rs b/crates/application/src/function_log.rs
@@ -527,12 +527,6 @@ pub struct FunctionExecutionLog<RT: Runtime> {
     rt: RT,
 }
 
-impl<RT: Runtime> HeapSize for FunctionExecutionLog<RT> {
-    fn heap_size(&self) -> usize {
-        self.inner.lock().heap_size()
-    }
-}
-
 impl<RT: Runtime> FunctionExecutionLog<RT> {
     pub fn new(rt: RT, usage_tracking: UsageCounter, log_manager: Arc<dyn LogSender>) -> Self {
         let inner = Inner {
@@ -1228,12 +1222,6 @@ struct Inner<RT: Runtime> {
     metrics: Metrics,
 }
 
-impl<RT: Runtime> HeapSize for Inner<RT> {
-    fn heap_size(&self) -> usize {
-        self.log.heap_size() + self.log_waiters.heap_size()
-    }
-}
-
 impl<RT: Runtime> Inner<RT> {
     fn log_execution(
         &mut self,

diff --git a/crates/database/src/database.rs b/crates/database/src/database.rs
@@ -137,7 +137,6 @@ use usage_tracking::{
     UsageCounter,
 };
 use value::{
-    heap_size::HeapSize,
     id_v6::DeveloperDocumentId,
     Size,
     TableNamespace,
@@ -2018,10 +2017,6 @@ impl<RT: Runtime> Database<RT> {
         self.usage_counter.clone()
     }
 
-    pub fn write_log_size(&self) -> usize {
-        self.log.heap_size()
-    }
-
     pub fn search_storage(&self) -> Arc<dyn Storage> {
         self.search_storage
             .get()

diff --git a/crates/database/src/write_log.rs b/crates/database/src/write_log.rs
@@ -360,12 +360,6 @@ impl LogReader {
     }
 }
 
-impl HeapSize for LogReader {
-    fn heap_size(&self) -> usize {
-        self.inner.read().heap_size()
-    }
-}
-
 /// LogWriter can append to the log.
 pub struct LogWriter {
     inner: Arc<RwLock<WriteLog>>,