Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display icon next to balance in the pop up or remove it if it cannot be displayed properly #1567

Closed
MoritzKa opened this issue Oct 5, 2022 · 5 comments · Fixed by #1579
Closed
Assignees
Labels
bug Something isn't working frontend All things frontend development related good first issue Good for newcomers
Milestone

Comments

@MoritzKa
Copy link
Contributor

MoritzKa commented Oct 5, 2022

Describe the bug

The (bee?) icon is not displayed properly on Chrome (Windows)

Screenshots of the changes [optional]

5kdjIvopc8

To Reproduce

Steps to reproduce the behavior:

  1. Open the extension
  2. Select an Alby account

Expected behavior

a properly displayed icon or no icon at all

Alby information

  • Alby Version: [e.g. 1.5.0]
  • Alby installed through [e.g. installed through the browser stores, installed manually]
  • Wallet connected with Alby [e.g. LND, BlueWallet LNDhub]

Device information [optional]

  • OS: Windows
  • Browser: Chrome and Firefox
  • Browser Version: Chrome Version 105.0.5195.127

Are you working on this issue?

No

@MoritzKa
Copy link
Contributor Author

MoritzKa commented Oct 5, 2022

not super urgent. but fix should be quick anyway.

@MoritzKa MoritzKa added the bug Something isn't working label Oct 5, 2022
@bumi
Copy link
Collaborator

bumi commented Oct 5, 2022

finally somebody reports that. this has been there forever :)
it is because we cut off the emoji (which comes from the alby lnd node alias) in the middle. - substr is not utf8 aware.

@escapedcat escapedcat added frontend All things frontend development related good first issue Good for newcomers labels Oct 6, 2022
@rottingcleaner
Copy link
Contributor

LNbits works great.

Screenshot 2022-10-06 at 19 59 41(1)

@escapedcat
Copy link
Contributor

@rottingcleaner that name is short enough ;)
This i.e. looks bad:
image

If it's longer it will break, because we use substring:
https://github.com/getAlby/lightning-browser-extension/blob/master/src/app/components/AccountMenu/index.tsx/#L40

I think this should be handled via CSS (ellipsis) instead of JS cutting of the string hard.

@rottingcleaner
Copy link
Contributor

@escapedcat I saw the line, then tested with my LNbits account and it was fine ;)

A CSS solution is a better way to cut the title on this place.

@reneaaron reneaaron added this to the v1.18 milestone Oct 8, 2022
@escapedcat escapedcat moved this to In Progress in 🐝 Alby Oct 10, 2022
Repository owner moved this from In Progress to Done in 🐝 Alby Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend All things frontend development related good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants