Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncate account title #1579

Merged
merged 1 commit into from
Oct 16, 2022
Merged

fix: truncate account title #1579

merged 1 commit into from
Oct 16, 2022

Conversation

rottingcleaner
Copy link
Contributor

Describe the changes you have made in this PR

This change is about the account title. Replace JS cutting by a CSS solution. The full account title is displayed on mouse over (title attribute).

Link this PR to an issue

Fixes #1567

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Short title
Screenshot 2022-10-07 at 08 49 21

Long title
Screenshot 2022-10-07 at 08 59 13

Long title mouse over
Screenshot 2022-10-07 at 08 59 27

How has this been tested?

yarn run dev:chrome

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep stacking sats!

@escapedcat escapedcat requested a review from im-adithya October 7, 2022 07:38
Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Edge cases are weird, but that's not part of this issue, I think.
If users complain about this we can tackle it later on.
image

@escapedcat escapedcat requested a review from bumi October 7, 2022 08:04
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your contribution! 🚀💯

utACK

@bumi bumi merged commit 60905cc into getAlby:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display icon next to balance in the pop up or remove it if it cannot be displayed properly
4 participants