Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nostr: Read and write request permission from DB #1727

Closed
3 tasks
lisabaut opened this issue Nov 8, 2022 · 0 comments · Fixed by #1775
Closed
3 tasks

Nostr: Read and write request permission from DB #1727

lisabaut opened this issue Nov 8, 2022 · 0 comments · Fixed by #1775
Assignees
@escapedcat
Labels
idea A feature idea that needs to be more specification
Milestone
v1.20

Comments

@lisabaut
Copy link
Contributor

lisabaut commented Nov 8, 2022 •
edited
Loading

Feature description

This pull request #1724
extended the DB with the table "permissions".

Now, it is possible to get, add, delete a permission for a specific host/allowance.
The integration of Nostr enables two methods at the moment:

  • ConfirmSignMessage
  • ConfirmGetPublicKey

Both methods can now be saved in the DB (if the user decides to save them in order to be not asked again).

Describe the solution

TODO

  • extend ConfirmSignMessage with checking first if the permission for this request exists, save this permission otherwise
  • do the same for ConfirmGetPublicKey
  • decide if this flow should happen within the Prompt or within the background script

Describe alternatives

...

Additional context

No response

Are you working on this?

No response
@lisabaut lisabaut added the idea A feature idea that needs to be more specification label Nov 8, 2022
@im-adithya im-adithya self-assigned this Nov 9, 2022
@bumi bumi added this to the v1.20 milestone Nov 14, 2022
@bumi bumi added this to 🐝 Alby Nov 21, 2022
@bumi bumi moved this to Ready to be worked on in 🐝 Alby Nov 21, 2022
escapedcat added a commit that referenced this issue Nov 22, 2022
@escapedcat
feat(nostr): support permission vor signMessage #1727
a108956
@escapedcat escapedcat mentioned this issue Nov 22, 2022
Merged
escapedcat added a commit that referenced this issue Nov 23, 2022
@escapedcat
feat(nostr): apply enable to support unlock #1727
335738e
escapedcat added a commit that referenced this issue Nov 23, 2022
@escapedcat
revert(nostr): enable from handling #1727
fc74953
escapedcat added a commit that referenced this issue Nov 23, 2022
@escapedcat
chore: some linting #1727
2d39f40
escapedcat added a commit that referenced this issue Nov 23, 2022
@escapedcat
revert(nostr): enable from handling #1727
0e4661e
@escapedcat escapedcat assigned escapedcat and unassigned im-adithya Nov 23, 2022
escapedcat added a commit that referenced this issue Nov 23, 2022
@escapedcat
chore: some linting #1727
b46306c
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor: call enable from provider #1727
ed24a95
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor(nostr): remove enable from provide because we always need to…
8b06d2f 
… check for unlock #1727
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor(nostr): use await #1727
d2dde89
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor(nostr): use dexie api to find permission #1727
56d0cb6
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor(nostr): utilize addPermission action #1727
2acb7aa
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor(nostr): utilize addPermission action #1727
7a8b1df
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
revert: enable action sender #1727
cc4f5bb
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
chore(nostr): remove outdated type #1727
dd542f1
escapedcat added a commit that referenced this issue Nov 25, 2022
@escapedcat
refactor(nostr): use diexie api to get boolean #1727
0ae37e1
escapedcat added a commit that referenced this issue Nov 28, 2022
@escapedcat
refactor(permissions): use permission enum #1727
757b296
escapedcat added a commit that referenced this issue Nov 28, 2022
@escapedcat
feat(nosrt): i18n #1727
e1eeec1
escapedcat added a commit that referenced this issue Nov 28, 2022
@escapedcat
refactor(nostr): use request approach, femove unused code #1727
0c7a9fd
@escapedcat escapedcat moved this from Ready to be worked on to In Progress in 🐝 Alby Nov 28, 2022
escapedcat added a commit that referenced this issue Nov 28, 2022
@escapedcat
feat(nostr): i18n #1727
b007c2e
escapedcat added a commit that referenced this issue Nov 28, 2022
@escapedcat
refactor(nostr): use request approach, remove unused code #1727
29d91dc
escapedcat added a commit that referenced this issue Nov 28, 2022
@escapedcat
chore(nostr): remove unused code #1727
ad90f92
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
feat(nostr): support permission vor signMessage #1727
b4f5110
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
feat(nostr): apply enable to support unlock #1727
1b48c60
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
chore: some linting #1727
208409a
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
revert(nostr): enable from handling #1727
762432e
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
chore: some linting #1727
f978706
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor: call enable from provider #1727
880e75a
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): remove enable from provide because we always need to…
af6e7c8 
… check for unlock #1727
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): use await #1727
d2dad98
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): use dexie api to find permission #1727
923fe6e
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): utilize addPermission action #1727
3ad87cd
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
revert: enable action sender #1727
7a35c27
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
chore(nostr): remove outdated type #1727
66f7dab
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): use diexie api to get boolean #1727
411765f
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(permissions): use permission enum #1727
3ceacf4
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
feat(nostr): i18n #1727
4188426
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): use request approach, remove unused code #1727
b68713a
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
chore(nostr): remove unused code #1727
ed4c0cf
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): use dexie get #1727
9415b9c
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
chore(nostr): delete outdated types #1727
a242bfc
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
feat(nostr): adjust i18n #1727
cf64acf
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
fix(nostr): block is false initially #1727
80895b8
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): align with request-action #1727
178a6ad
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): nostr types #1727
2e13ecd
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
refactor(nostr): align with request-action #1727
80b4dc5
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
chore(nostr): remove unsused confirm #1727
0a84100
escapedcat added a commit that referenced this issue Nov 29, 2022
@escapedcat
fix(nostr): types after rebase #1727
db8feca
bumi pushed a commit that referenced this issue Nov 29, 2022
@escapedcat
feat(nostr): support permission for signMessage #1727 (#1775)
77689b8 
* feat(nostr): support permission vor signMessage #1727

* feat(nostr): apply enable to support unlock #1727

* chore: some linting #1727

* revert(nostr): enable from handling #1727

* chore: some linting #1727

* refactor: call enable from provider #1727

* refactor(nostr): remove enable from provide because we always need to check for unlock #1727

* refactor(nostr): use await #1727

* refactor(nostr): use dexie api to find permission #1727

* refactor(nostr): utilize addPermission action #1727

* revert: enable action sender #1727

* chore(nostr): remove outdated type #1727

* refactor(nostr): use diexie api to get boolean #1727

* refactor(permissions): use permission enum #1727

* feat(nostr): i18n #1727

* refactor(nostr): use request approach, remove unused code #1727

* chore(nostr): remove unused code #1727

* refactor(nostr): use dexie get #1727

* chore(nostr): delete outdated types #1727

* feat(nostr): adjust i18n #1727

* fix(nostr): block is false initially #1727

* refactor(nostr): align with request-action #1727

* refactor(nostr): nostr types #1727

* refactor(nostr): align with request-action #1727

* chore(nostr): remove unsused confirm #1727
Repository owner moved this from In Progress to Done in 🐝 Alby Nov 29, 2022
bumi added a commit that referenced this issue Nov 30, 2022
@bumi
Merge branch 'chore/load-connector-onunlock' into feature/request-method
902117a 
# By Lisa Oppermann (19) and others
# Via GitHub (27) and others
* chore/load-connector-onunlock: (66 commits)
  chore: load and initialize connector on unlock
  Translated using Weblate (Chinese (Simplified))
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Esperanto)
  Feature/dual currency input (#1780)
  feat(nostr): support permission for signMessage #1727 (#1775)
  Update axios to version 1.2.0
  chore: update wext-manifest-loader
  Added translation using Weblate (Esperanto)
  Update @types/chrome to version 0.0.203
  test(bluewallet): remove failing e2e test
  Update @trivago/prettier-plugin-sort-imports to version 4.0.0
  chore(deps): update swc
  chore(deps): update swc
  chore(deps): update tests to get rid of extra dep
  chore(deps): ignore swc cache folder
  chore(deps): remove swc cache folder
  chore(deps): update swc to latest
  chore: add workaround for swc above v205
  Translated using Weblate (Chinese (Simplified))
  ...

# Conflicts:
#	package.json
#	src/app/components/AllowanceMenu/index.test.tsx
#	src/app/screens/ConfirmKeysend/index.test.tsx
#	src/app/screens/ConfirmPayment/index.test.tsx
#	src/app/screens/Keysend/index.tsx
#	src/app/screens/LNURLPay/index.test.tsx
#	src/app/screens/Publishers/index.test.tsx
#	src/i18n/locales/fi/translation.json
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@escapedcat escapedcat

Labels
idea A feature idea that needs to be more specification
Projects
🐝 Alby
Archived in project
Milestone
v1.20
Development

Successfully merging a pull request may close this issue.

feat(nostr): support permission for signMessage #1727 getAlby/lightning-browser-extension
4 participants
@bumi @escapedcat @lisabaut @im-adithya