Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-encrypt the nostr key when changing the password #1925

Closed
1 task done
bumi opened this issue Dec 30, 2022 · 0 comments · Fixed by #1930
Closed
1 task done

Re-encrypt the nostr key when changing the password #1925

bumi opened this issue Dec 30, 2022 · 0 comments · Fixed by #1930
Assignees
@escapedcat
Milestone
v1.21

Comments

@bumi
Copy link
Collaborator

bumi commented Dec 30, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When changing the password the nostr key is not encrypted with the new password.

Screenshots [optional]

No response

Steps To Reproduce

Expected behavior

Alby information

master

Device information

No response

Additional context

No response

Are you working on this?

None
@reneaaron reneaaron changed the title Re-encrypt the nostr key when chaning the password Re-encrypt the nostr key when changing the password Dec 30, 2022
@reneaaron reneaaron modified the milestones: v1.22, v1.21 Jan 2, 2023
@escapedcat escapedcat assigned escapedcat and unassigned bumi and reneaaron Jan 2, 2023
@escapedcat escapedcat moved this to In Progress in 🐝 Alby Jan 2, 2023
escapedcat added a commit that referenced this issue Jan 2, 2023
@escapedcat
fix(nostr): re-encrypt nostr key on pw change #1925
d36dab4
@escapedcat escapedcat mentioned this issue Jan 2, 2023
Merged
escapedcat added a commit that referenced this issue Jan 3, 2023
@escapedcat
fix(nostr): handle failing key decrypt #1925
7224a68
escapedcat added a commit that referenced this issue Jan 3, 2023
@escapedcat
fix(nostr): handle failing key decrypt #1925
f2c3a36
reneaaron pushed a commit that referenced this issue Jan 3, 2023
@escapedcat
fix(nostr): re-encrypt nostr key on pw change #1925 (#1930)
1cc33c8 
* fix(nostr): re-encrypt nostr key on pw change #1925

* fix(nostr): handle failing key decrypt #1925

* fix(nostr): handle failing key decrypt #1925
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🐝 Alby Jan 3, 2023
bumi added a commit that referenced this issue Jan 3, 2023
@bumi
Merge branch 'master' into feat/nostr-nip-19
894ca1a 
* master: (38 commits)
  Update translation files
  Update translation files
  Update translation files
  Update translation files
  fix(nostr): re-encrypt nostr key on pw change #1925 (#1930)
  test(e2e): fix alby wallet tests #1848
  test(e2e): fix alby wallet tests #1848
  Update translation files
  Translated using Weblate (German)
  fix: copy
  chore: add forgot password link
  fix: copy
  fix: copy
  chore: remove Settings link from navbar
  Translated using Weblate (German)
  Update all development Yarn dependencies (2022-12-31)
  Update react-router-dom to version 6.6.1
  fix: unit test query casing
  chore: update lightning and bitcoin casing
  fix: rename Discover component
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@escapedcat escapedcat

Labels
None yet
Projects
🐝 Alby
Archived in project
Milestone
v1.21
Development

Successfully merging a pull request may close this issue.

fix(nostr): re-encrypt nostr key on pw change #1925 getAlby/lightning-browser-extension
3 participants
@bumi @escapedcat @reneaaron