Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LNC and Umbrel LND connrectors content #2258

Closed
stackingsaunter opened this issue Mar 23, 2023 · 8 comments · Fixed by #2326
Closed

Update LNC and Umbrel LND connrectors content #2258

stackingsaunter opened this issue Mar 23, 2023 · 8 comments · Fixed by #2326
Assignees
Labels
good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

Umbrel connector content is out of date. Both copy and video there relates to previous Umbrel design:
Screenshot 2023-03-23 at 11 30 45

Let's update the copy with:

  1. In your Lightning Node dashboard go to Connect wallet
  2. Select REST (Tor) or REST (Local Network) mode
  3. Copy the lndconnect URL and paste it below

And change the video to this screenshot:

image


We can update LNC connector as well.

Current version:
Screenshot 2023-03-23 at 11 40 51

Updated copy:

  1. On Lightning Terminal sidebar choose Lightning Node Connect
  2. Click Create a new session
  3. Label the session, choose desired permissions and submit
  4. Copy pairing phrase and paste it below

Added screenshot (insead of Alby logo):
image

@stackingsaunter stackingsaunter added the good first issue Good for newcomers label Mar 23, 2023
@AdarshRawat1
Copy link
Contributor

I can tackle this issue!

@stackingsaunter
Copy link
Contributor Author

@AdarshRawat1 great, go for it

@mviswanathsai
Copy link
Contributor

Can I be assigned this issue, if no one else is working on it?

@AdarshRawat1
Copy link
Contributor

AdarshRawat1 commented Apr 8, 2023

@mviswanathsai Thank you for your willingness to address this matter. However, I am currently handling it. Please feel free to explore any other issues that may catch your attention.

@mviswanathsai
Copy link
Contributor

@AdarshRawat1 I am sorry but since the issue has been assigned long back I assumed no one is working on it and have created a PR.

@mviswanathsai
Copy link
Contributor

@stackingsaunter I have solved this issue, is it ok if I link the PR here? Sorry I just started working on it since it seemed to be inactive.

@AdarshRawat1
Copy link
Contributor

@mviswanathsai I apologize for any misunderstanding.

@mviswanathsai
Copy link
Contributor

@AdarshRawat1 it's all good, no issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants