Updated LNC and Umbrel LND connector's content #2326
Conversation
-Updated the Umbrel connector content - by adding the screenshot of updated design of Umbrel instead of video.
-Added screenshot in LNC connector(instead of Alby logo)
There was a problem hiding this comment.
Thanks for your PR @AdarshRawat1! 💪
I noticed some layout issues on smaller screen sizes:
The screenshot here seems to be displayed very small. I'd suggest removing the width restrictions for those kinds of images and displaying them full-width:
Thanks for your contribution! 🙌
- Removed the width constraints from Screenshots to improve responsive display.
- added lnc and umbel screenshot to repository in assets\images\connectors\lnc\ and assets\images\connectors\umbel\
respectively.
- changed - <img src={`${image}`} ../>
to - <img src={image} ... />
in
src/app/components/ConnectorForm/index.tsx
|
@reneaaron, I have made the suggested changes. Could you please review them? |
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
There was a problem hiding this comment.
Added 2 more commits where I moved the images to the CDN instead of shipping it with the extension.
Also added some more improvements for formatting & some bugfixes, please have a look.
tACK
Thanks for your contribution @AdarshRawat1 🙌
Thank you, @reneaaron, for your guidance and moving the images to the CDN. |
Describe the changes you have made in this PR
Link this PR to an issue [optional]
Fixes #2258
Type of change
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Current Umbrel connector instructions
Updated Umbrel connector Instructions
Changed the video to screenshot on Umbrel connector
Current LND connector -
Updated instructions on LNDconnector
Added screenshot in LND connector
Checklist