Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Correct upper helper text in inputs coloring #2291

Closed
stackingsaunter opened this issue Mar 29, 2023 · 10 comments · Fixed by #2317
Closed

[BUG] Correct upper helper text in inputs coloring #2291

stackingsaunter opened this issue Mar 29, 2023 · 10 comments · Fixed by #2317
Assignees
Labels
bug Something isn't working frontend All things frontend development related good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

Current upper helper text in inputs is black in both light and dark theme (currently used only for range amounts defined by LNURL).

Screenshot 2023-03-29 at 23 53 17

Screenshot 2023-03-29 at 23 47 26

This element should have different colors:
Light theme: gray-700
Dark theme: neutral-400

Screenshot 2023-03-29 at 23 56 23

@stackingsaunter stackingsaunter added bug Something isn't working good first issue Good for newcomers frontend All things frontend development related labels Mar 29, 2023
@PUJAmangale1221
Copy link

Hey Maintainers, I would like to resolve this issue could you please help me to go ahead...!!

@ghost
Copy link

ghost commented Mar 30, 2023

Hi, I'm Jakub, I would like to do this issue but I don't know where to start if you can help me

@stackingsaunter
Copy link
Contributor Author

@PUJAmangale1221 @devjakubN I think this guide is a good place to start https://github.com/getAlby/lightning-browser-extension/blob/master/doc/CONTRIBUTION.md

@SveeJ
Copy link

SveeJ commented Mar 31, 2023

Hi! Could I please be assigned this issue?

@Pratik-A-N
Copy link
Contributor

Is this issue under review or I can work on this ??

@stackingsaunter
Copy link
Contributor Author

@SveeJ are you working on this or can @Pratik-A-N take over?

@stackingsaunter
Copy link
Contributor Author

I am assigning you, @Pratik-A-N go ahead

@stackingsaunter stackingsaunter assigned Pratik-A-N and unassigned SveeJ Apr 5, 2023
@SveeJ
Copy link

SveeJ commented Apr 5, 2023

Hi sorry for the late response. Was not present for health reasons. I'm glad it's taken over.

@Pratik-A-N
Copy link
Contributor

Screenshot from 2023-04-07 02-32-54
Hi, I'm not able to see the text whose style needs to be fixed. @stackingsaunter can you please tell how do I regenerate this issue in my local setup??

@stackingsaunter
Copy link
Contributor Author

@Pratik-A-N you can see them by pasting those LNURL invoices into Send

https://github.com/getAlby/lightning-browser-extension/wiki/%F0%9F%A4%A0-Alby-in-the-wild#lnurls

Screenshot 2023-04-07 at 13 38 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend All things frontend development related good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants