Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style disabled state of inputs #2292

Closed
stackingsaunter opened this issue Mar 29, 2023 · 5 comments · Fixed by #2298
Closed

Style disabled state of inputs #2292

stackingsaunter opened this issue Mar 29, 2023 · 5 comments · Fixed by #2298
Assignees
@Pratik-A-N
Labels
frontend All things frontend development related good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

This design is dependent and assumes this update #2237 to input will occur (mostly moving fiat amount inside the input) and that those corrections to helper (amount) input will be made #2291

Current disabled input state (eg. Nostr public key) look the same as filled state, which may cause bad UX for people in some cases.

I propose making disabled state visually different, like this (only inside of the input changes the styling):

Light theme: input bg: gray50
Dark theme: input bg: surface16dp
Text inside the input (both themes): gray500

Screenshot 2023-03-29 at 23 58 47
@stackingsaunter stackingsaunter added good first issue Good for newcomers frontend All things frontend development related labels Mar 29, 2023
@Pratik-A-N
Copy link
Contributor

Hello, can I work on this issue ??

@stackingsaunter
Copy link
Contributor Author

Yes, of course

This was referenced Mar 31, 2023
Closed
Closed
Merged
@Pratik-A-N
Copy link
Contributor

I have made a PR can you please review it @stackingsaunter ??

@Pratik-A-N
Copy link
Contributor

I have now used the prettier format and changed the files accordingly but am not able to get why the E2E test failed?? can you please explain

@stackingsaunter
Copy link
Contributor Author

@Pratik-A-N will test it again when build will be updated by github bot^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pratik-A-N Pratik-A-N

Labels
frontend All things frontend development related good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: style disabled state of inputs Pratik-A-N/lightning-browser-extension
2 participants
@stackingsaunter @Pratik-A-N