Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide optional inputs under "More" button on transacting screens #2370

Closed
stackingsaunter opened this issue Apr 24, 2023 · 1 comment · Fixed by #2373
Closed

Hide optional inputs under "More" button on transacting screens #2370

stackingsaunter opened this issue Apr 24, 2023 · 1 comment · Fixed by #2373
Assignees
@lujakob
Labels
frontend All things frontend development related good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

stackingsaunter commented Apr 24, 2023 •
edited
Loading

Solves #1662

Currently, users when transacting, almost always need to scroll down to see buttons to cancel or send the payment, eg:

Screenshot 2023-04-25 at 00 43 21

Let's hide those under "More" button/link, so action buttons will be seen immediately:

Screenshot 2023-04-25 at 00 44 55

PR requirements:

  • Must involve all transacting screens with optional fields hidden in this way in the popup view
  • Does not need to be implemented in extended (desktop) view
  • Link default state color is blue600 and blue700 on hover (both light and dark theme)
@stackingsaunter stackingsaunter added good first issue Good for newcomers frontend All things frontend development related labels Apr 24, 2023
@lujakob
Copy link
Contributor

lujakob commented Apr 25, 2023

I'll pick it.

@lujakob lujakob mentioned this issue Apr 25, 2023
Merged
3 tasks
@reneaaron reneaaron mentioned this issue Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lujakob lujakob

Labels
frontend All things frontend development related good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: lnurlpay screen toggle more fields lujakob/lightning-browser-extension
2 participants
@lujakob @stackingsaunter