feat: lnurlpay screen toggle more fields

[lujakob]

Describe the changes you have made in this PR

Toggle more fields on lnurlpay screen to have buttons visible.

Link this PR to an issue

Fixes #2370

Type of change

(Remove other not matching type)

• feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

How has this been tested?

Manually

Checklist

• My code follows the style guidelines of this project and performed a self-review of my own code
• New and existing tests pass locally with my changes
• I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: channel.ninja (who recently dropped 1000 sats):

---

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

[lujakob]

@stackingsaunter regarding your requirements:

• Must involve all transacting screens with optional fields hidden in this way in the popup view
  I checked all screens that are linked from the "Send" screen and found none, except lnurlpay screen (which is the one in your design). I have nothing in mind and am not aware of how to skip through all possibilities/screens. Is there anything I missed?

• Link default state color is blue600 and blue700 on hover (both light and dark theme)
  As the recommended colors didn't show up in the IDE classes auto suggestion I searched for font color classes in the project and found the Hyperlink component utilizing text-blue-700 hover:text-blue-500. The only place this component is used is in Unlock and ConfirmSignMessage. Anyways, I just used the Hyperlink here as well.

[stackingsaunter]

• Must involve all transacting screens with optional fields hidden in this way in the popup view

I am not aware how it is structured in the code. I know that different optional fields appear depending on LNURL, eg:

But it seems it works for all in this build!

• I just used the Hyperlink here as well.

That's OK, Rene will update hyperlink colors separately

Thanks @lujakob for this PR!

[stackingsaunter]

@lujakob hey I discussed the change with @reneaaron and we decided to pull of "Comment" input out of "More", as this is quite often used and important field. Could you move it out?

This will make users still need to scroll, but I am working on changing other elements (ln address box) to make it all fit, but that will be a seperate issue.

Also, could you delete the 1px border/divider above the buttons as well? Thank you!

[lujakob]

@lujakob hey I discussed the change with @reneaaron and we decided to pull of "Comment" input out of "More", as this is quite often used and important field. Could you move it out?

This will make users still need to scroll, but I am working on changing other elements (ln address box) to make it all fit, but that will be a seperate issue.

Also, could you delete the 1px border/divider above the buttons as well? Thank you!

@stackingsaunter

• I moved the comment field to always display
• I removed the border as suggested
• I cleaned up the margin/paddings. At least it's possible to notice there is more UI coming (see screens)

[stackingsaunter]

tACK

[reneaaron]

Thanks @lujakob, awesome job! 👍 (Great that you extracted those inline checks into methods, a lot easier to read now!)

tACK