Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] QR code is not scannable #2774

Closed
1 task done
rolznz opened this issue Sep 23, 2023 · 3 comments · Fixed by #2785
Closed
1 task done

[BUG] QR code is not scannable #2774

rolznz opened this issue Sep 23, 2023 · 3 comments · Fixed by #2785
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@rolznz
Copy link
Contributor

rolznz commented Sep 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

QR code is not scannable for "leo@getalby.com". I wonder if the short LN address makes the QR less detailed, and therefore the icon hides too much of the QR.

Screenshots [optional]

image

Steps To Reproduce

Try scan the above screenshot, or hardcode the app to use leo's LN address.

Expected behavior

QR should be scannable.

Alby information

3.2.1

Device information

No response

Additional context

No response

Are you working on this?

None

@rolznz rolznz added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Sep 23, 2023
@volfiros
Copy link
Contributor

@rolnz I would like to work on this issue, can you assign this to me.
Some ways to overcome this issue are - Bigger qr size, smaller icon or higher error correction level.
I feel using higher error correction level would be a best way, currently we are using medium level but using quartile level will fix this issue (works fine for 1 character lightning address names too)

@bumi
Copy link
Collaborator

bumi commented Sep 23, 2023

sounds good @Rithvik-padma

@AnamuddinAhmad
Copy link

@rolznz I'M INTRESTED WORK ON THIS TECHNOLOGY CAN YOU ASSING ME PLEASE ?

rolznz added a commit that referenced this issue Oct 2, 2023
fix: made the QR code scannable for even shorter lightning addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
4 participants