fix: change regex to match lightning emoji #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
force-pushed
the
task-github-tipping
branch
from
15b8bfb to
07ab48c
Compare
19 tasks
bumi
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Note: [For Linux (and Windows?)]
GitHub tipping is not currently working as the regex only checks for the lightning symbol but GitHub changes it to a g-emoji node everywhere (in bio and readme). This PR changes the regex to help find the zap (:zap:) emoji and the lightning address to support tipping!
Link this PR to an issue
--
Type of change (Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes (If any)
Add screenshots to help explain your problem
How has this been tested?
alby.mp4
Checklist