refactor!: manifest v3 support #1051 #1124

escapedcat · 2022-07-08T07:07:05Z

CURRENT FINDINGS ALL GOOD SO FAR

~~Axios doesn't seem to work in background-scripts, might need to switch (back) to fetch~~:
https://stackoverflow.com/questions/66305856/typeerror-adapter-is-not-a-function-error-when-using-axios-and-webpack-in-chrom/70206333#70206333
~~No (extrenal) images~~
~~No external API calls~~
~~Just switching current code to use web workers doesn't work~~

Describe the changes you have made in this PR

Trying to prepare the switch to v3

Link this PR to an issue

Fixes #1051

Type of change (Remove other not matching type)

refactor: Breaking refactor

How has this been tested?

...not yet

Checklist

My code follows the style guidelines of this project and performed a self-review of my own code
New and existing tests pass locally with my changes
I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

github-actions · 2022-07-08T07:12:18Z

Build files:

src/manifest.json

github-actions · 2022-08-23T06:36:15Z

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: Moritz (who recently dropped 1000 sats):

Merry Christmas to the Alby team

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

escapedcat · 2023-02-13T14:02:06Z

popup doesn't close on "lock" (in chrome/osx)

I suspect this: https://github.com/getAlby/lightning-browser-extension/pull/2025/files#diff-3eda5a900b82096e98a0204c9e75d6b1d1b5e212de86fca7e6d107b123c0b412R125

...).extension.getViews is not a function

Yup, let me have a look

Findings:

https://developer.chrome.com/docs/extensions/mv3/mv3-migration-checklist/#api-background-context

RESULT: fixed ✅

src/extension/background-script/state.ts

escapedcat · 2023-03-02T13:39:16Z

src/extension/background-script/actions/setup/reset.ts

@@ -3,11 +3,11 @@ import type { MessageReset } from "~/types";
 import state from "../../state";

 const reset = async (message: MessageReset) => {
+  await state.getState().password(null);


@im-adithya please check if this is correct. Just adjusted it according to the mv3 way of handling the password.

escapedcat · 2023-03-20T15:09:31Z

COMMANDO / LNMESSAGE UPDATE

Status

Commando was already tested and checked ✅ above.

Now this didn't work anymore:

Findings

Commando connector worked here: 43a4091
Commando connector did not work here anymore: dd85f9a

What happened in between?: lnmessage v.01.0

Assumption is we do not have a window object in the SW. Reverting this works:
lnbc1QWFyb24/lnmessage@3d00360#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80L159-R164

Solution

Reverting back to lnmessage v0.0.19 is fixing this for now

escapedcat · 2023-03-20T16:31:02Z

DEBUG ALBY (USING) WINDOW

Status

escapedcat force-pushed the refactor/manifest-v3-support branch from 82bc8a9 to 9a2c69f Compare July 11, 2022 07:26

bumi reviewed Jul 12, 2022

View reviewed changes

src/manifest.json Outdated Show resolved Hide resolved

escapedcat force-pushed the refactor/manifest-v3-support branch from fc57c7d to 363a87c Compare July 13, 2022 10:26

escapedcat added a commit that referenced this pull request Jul 14, 2022

fix(axios): use fetach-adapter within service-worker #1124

2804f1f

escapedcat force-pushed the refactor/manifest-v3-support branch from 363a87c to 2804f1f Compare July 14, 2022 09:31

escapedcat added a commit that referenced this pull request Jul 14, 2022

fix(axios): use fetach-adapter within service-worker #1124

e958323

escapedcat force-pushed the refactor/manifest-v3-support branch from 2804f1f to e958323 Compare July 14, 2022 09:39

escapedcat added a commit that referenced this pull request Jul 14, 2022

fix(axios): use fetach-adapter within service-worker #1124

686eb1a

escapedcat force-pushed the refactor/manifest-v3-support branch from e958323 to 686eb1a Compare July 14, 2022 09:42

escapedcat added a commit that referenced this pull request Jul 14, 2022

fix(axios): use fetach-adapter within service-worker #1124

63f570a

escapedcat force-pushed the refactor/manifest-v3-support branch from 686eb1a to 63f570a Compare July 14, 2022 10:18

This comment was marked as outdated.

Sign in to view

escapedcat added a commit that referenced this pull request Jul 19, 2022

fix(axios): use fetach-adapter within service-worker #1124

5c1c617

escapedcat force-pushed the refactor/manifest-v3-support branch from 63f570a to 5c1c617 Compare July 19, 2022 03:47

escapedcat added a commit that referenced this pull request Aug 23, 2022

fix(axios): use fetach-adapter within service-worker #1124

4ce4034

escapedcat force-pushed the refactor/manifest-v3-support branch from 5c1c617 to 4ce4034 Compare August 23, 2022 06:29

escapedcat added a commit that referenced this pull request Sep 1, 2022

fix(axios): use fetach-adapter within service-worker #1124

cc8fcc7

escapedcat force-pushed the refactor/manifest-v3-support branch from 4ce4034 to cc8fcc7 Compare September 1, 2022 07:10

escapedcat added a commit that referenced this pull request Sep 1, 2022

fix(axios): use fetach-adapter within service-worker #1124

601fca6

escapedcat force-pushed the refactor/manifest-v3-support branch from cc8fcc7 to a6bdc08 Compare September 1, 2022 07:32

escapedcat added 5 commits September 9, 2022 11:29

refactor!: manifest v3 support #1051

58d6307

refactor!: fix manifest v3 errors #1051

7f61c9a

test: update ext-id finding #1051

992efc5

fix(axios): use fetach-adapter within service-worker #1124

a4c5d69

chore: update opera version #1051

902713c

escapedcat force-pushed the refactor/manifest-v3-support branch from a6bdc08 to 902713c Compare September 9, 2022 03:31

escapedcat added 2 commits September 9, 2022 11:42

revert: remove outdated function wich was added earlier in this PR #1051

3a21e4e

fix: use further axios adapters #1051

8321efb

reneaaron removed this from the v1.19 milestone Jan 23, 2023

im-adithya and others added 4 commits February 2, 2023 17:19

Merge branch 'master' into HEAD

1acacba

chore: merge master #1051

7acf4ae

test: fix nostr tests #1051

dd91efc

test: skip auth test till axios-fetch is fixed #1051

18fa751

escapedcat force-pushed the refactor/manifest-v3-support branch from 7be75ce to 18fa751 Compare February 7, 2023 13:22

Merge branch 'master' into refactor/manifest-v3-support

20fe751

This comment was marked as outdated.

Sign in to view

fix(lock): close tabs/popup for chrome and firefox #1051

26a9c5f

This comment was marked as outdated.

Sign in to view

bumi reviewed Feb 23, 2023

View reviewed changes

src/extension/background-script/state.ts Show resolved Hide resolved

fix: types after merge master #1051

b009251

escapedcat commented Mar 2, 2023

View reviewed changes

escapedcat added 3 commits March 2, 2023 14:42

fix: use further axios adapters #1051

43a4091

chore: merge master #1051

dd85f9a

fix(commando): revert lnmessage to v0.0.19 #1051

05802a9

escapedcat mentioned this pull request Mar 20, 2023

fix: support SW usage lnbc1QWFyb24/lnmessage#23

Merged

escapedcat added 4 commits March 22, 2023 10:22

fix(commando): use lnmessage 0.3.0 beta #1051

3ea8086

fix: window error within SW #1051

b695b58

chore: remove unused dep #1051

573268b

fix: use further axios adapters #1051

9b53a29

escapedcat requested a review from bumi March 22, 2023 10:28

escapedcat merged commit aafee44 into master Mar 22, 2023

escapedcat deleted the refactor/manifest-v3-support branch March 22, 2023 10:31

escapedcat restored the refactor/manifest-v3-support branch April 7, 2023 08:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!: manifest v3 support #1051 #1124

refactor!: manifest v3 support #1051 #1124

escapedcat commented Jul 8, 2022 •

edited

Loading

github-actions bot commented Jul 8, 2022

This comment was marked as outdated.

github-actions bot commented Aug 23, 2022 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

escapedcat commented Feb 13, 2023 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

escapedcat Mar 2, 2023

escapedcat commented Mar 20, 2023 •

edited

Loading

escapedcat commented Mar 20, 2023

refactor!: manifest v3 support #1051 #1124

refactor!: manifest v3 support #1051 #1124

Conversation

escapedcat commented Jul 8, 2022 • edited Loading

CURRENT FINDINGS ALL GOOD SO FAR

Describe the changes you have made in this PR

Link this PR to an issue

Type of change (Remove other not matching type)

How has this been tested?

Checklist

github-actions bot commented Jul 8, 2022

This comment was marked as outdated.

github-actions bot commented Aug 23, 2022 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

escapedcat commented Feb 13, 2023 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

escapedcat Mar 2, 2023

Choose a reason for hiding this comment

escapedcat commented Mar 20, 2023 • edited Loading

COMMANDO / LNMESSAGE UPDATE

Status

Findings

Solution

escapedcat commented Mar 20, 2023

DEBUG ALBY (USING) WINDOW

Status

escapedcat commented Jul 8, 2022 •

edited

Loading

github-actions bot commented Aug 23, 2022 •

edited

Loading

escapedcat commented Feb 13, 2023 •

edited

Loading

escapedcat commented Mar 20, 2023 •

edited

Loading