Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): add general lndhub connector #576 #1538

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

escapedcat
Copy link
Contributor

@escapedcat escapedcat commented Sep 28, 2022

Describe the changes you have made in this PR

  • Added general LNDHub connector (internally named lndhub-go)
  • Reworked the lndhub ocnnector to handle BlueWallet and the new one

Link this PR to an issue

Fixes #576

Type of change (Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes

  • image

How has this been tested?

  • Connected an Alby account
  • Connected an Bluewallet account

@github-actions
Copy link

github-actions bot commented Sep 28, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: null (who recently dropped 210 sats):

Checkout the Alby Lightning Mixtape: https://alby-mixtape.vercel.app - happy coding!

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep stacking sats!

@escapedcat escapedcat force-pushed the feat/576_lndhub-connector branch from 92a6fb1 to db76098 Compare September 28, 2022 08:11
@escapedcat escapedcat marked this pull request as ready for review September 28, 2022 08:26
@MoritzKa
Copy link
Contributor

The icon of the LNDhub connector has a different size than the others on the screenshot.

@MoritzKa
Copy link
Contributor

Can you try one of these?
Slice 8
Slice 8 (1)

@escapedcat
Copy link
Contributor Author

@MoritzKa updated it:
image

@MoritzKa
Copy link
Contributor

Thanks. Looks good.

@bumi
Copy link
Collaborator

bumi commented Sep 29, 2022

now we have 2 times "LndHub" written there.
We should call the other one then only BlueWallet and also set the account name there then to BlueWallet.

I would also move BlueWallet behind LNBits. BlueWallet's lndhub causes many problems as.

@escapedcat
Copy link
Contributor Author

Done
image

@escapedcat escapedcat force-pushed the feat/576_lndhub-connector branch 2 times, most recently from 11cfb74 to 8d6d9f0 Compare September 30, 2022 04:43
@escapedcat escapedcat force-pushed the feat/576_lndhub-connector branch from 8d6d9f0 to 88ffda5 Compare September 30, 2022 04:53
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
@escapedcat escapedcat merged commit e36e253 into master Oct 4, 2022
@escapedcat escapedcat deleted the feat/576_lndhub-connector branch October 4, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a LNDHub connector without BlueWallet brand
4 participants