Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use resultcard in confirmpayment #1563

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

Align the success screen of ConfirmPayment

Link this PR to an issue [optional]

#1379

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

Screenshot from 2022-10-04 15-57-15

How has this been tested?

Manually [Receive and Paste Invoice in Send]

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep stacking sats!

@escapedcat
Copy link
Contributor

That tab view looks off:
image
Is it missing the is-screen param?

@escapedcat escapedcat merged commit 847baf4 into master Oct 7, 2022
@escapedcat escapedcat deleted the task-align-screens branch October 7, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants