fix: input placeholder got cut (send) #1517 #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavgarg237
commented
Oct 8, 2022
vaibhavgarg237
force-pushed
the
showFullText
branch
from
2d69a4c to
2279ee8
Compare
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep stacking sats! |
escapedcat
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
@reneaaron what do you think about the texts? Should we improve these? Also see: #1517 (comment)
vaibhavgarg237
force-pushed
the
showFullText
branch
from
2279ee8 to
269837f
Compare
bumi
reviewed
Oct 17, 2022
| await user.type( | ||
| screen.getByLabelText("Invoice, Lightning Address or LNURL"), | ||
| screen.getByLabelText("Recipient"), |
There was a problem hiding this comment.
is Recipient a good word here?
Is an "invoice" a recipient?
bumi
reviewed
Oct 17, 2022
| @@ -451,8 +451,8 @@ | |||
| "title": "Waiting to scan" | |||
| }, | |||
| "input": { | |||
| "label": "Invoice, Lightning Address or LNURL", | |||
| "placeholder": "Paste invoice, lnurl or lightning address" | |||
| "label": "Recipient", | |||
There was a problem hiding this comment.
is Recipient a good word here?
Is an "invoice" a recipient?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Fixed Send UX: Too long input placeholder is being cut off
On tapping Send UX, the input field is having placeholder which is cut off in Portuguese. So added hint text and updated placeholder text
Link this PR to an issue [optional]
Fixes #1517
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes
Checkout below comments
How has this been tested?
Tests are passing locally, final image attached below
Checklist