refactor: remove act warnings for allowance-menu & lnurl-pay #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep stacking sats! |
escapedcat
approved these changes
Oct 11, 2022
| const [lnurlAuth, setLnurlAuth] = useState(false); | ||
| const [fiatAmount, setFiatAmount] = useState(""); | ||
| const { t } = useTranslation("components", { keyPrefix: "allowance_menu" }); | ||
| const { t: tCommon } = useTranslation("common"); | ||
|
|
||
| useEffect(() => { | ||
| if (budget !== "" && showFiat) { | ||
| (async () => { | ||
| const getFiat = async () => { |
There was a problem hiding this comment.
Ah! We do this in several places. This is better. Good to know, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
A quick fix for the test warnings (e.g. here):
getFiatValuegetFiatValueonly if sat value is definedgetFiatValuewas calledTest run: The warnings are gone => https://github.com/getAlby/lightning-browser-extension/actions/runs/3220138671
Type of change
fix: Bug fix (non-breaking change which fixes an issue)How has this been tested?
Simply by running yarn test:unit only.
Checklist