refactor: store currency rate in settings ref

[lisabaut]

Describe the changes you have made in this PR

This is a refactoring which resulted from out the discussion in PR #1614

• store latest currency rate in SettingContext ref instead of state to prevent a re-render
• when getFiatValue is called => always check if the currency in the state matches with the currency in the ref, and update otherwise
• => this ensures that the fiat value is calculated with the correct rate
• => this ensures that the latest currency rate is called from the background script only once when the currency changed
• Also wrap getFiatValue in a try/catch block and display an error when a sat to fiat conversion failed

Unfortunately this reverted a few commits from this PR again (sorry @escapedcat 🌷 )

FIXES

• fixes Sometimes fiat value appear as 0 but should show none info or other kind of rendering #1608
• and fixes bug from this comment:

This results in a similar problem when changing the currency on the Settings Page:
=> the fiatValue within the AccountMenu needs several steps to show the correct new value because the currencyRate gets updated after getFiatValue is called
=> "$38.76" (initial value) => change to CNY => "CN¥38.76" (correct currency, wrong value) => "CN¥79.65" (correct currency, correct value)

Screenshots

Try/Catch Toast Error

Link this PR to an issue [optional]

Fixes #1608

Type of change

• fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

• checking how the AccountMenu renders the fiatValue

Checklist

• My code follows the style guidelines of this project and performed a self-review of my own code
• New and existing tests pass locally with my changes
• I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

---

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

[bumi]

ups merged this other PR. sorry for the conflict

[escapedcat]

Awesome, thanks Lisa! Kinda missed the promises :P

[lisabaut]

@escapedcat Please review again. I added a try/catch block too and opened a ticket for a found bug
#1649

[escapedcat]

Right, some do not support certain currencies? Thanks!

[bumi]

why do we need the await her now again? because now we load the rate always when we do getFiatValue and in getCurrencyRate we check if it is already loaded, if nowt we load it throuh the api.getCurrencyRate() call?

correct?

[lisabaut]

As discussed. This can be merged