Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable input fields on Create Invoice #1659 #1668

Merged
merged 1 commit into from
Oct 27, 2022
Merged

fix: disable input fields on Create Invoice #1659 #1668

merged 1 commit into from
Oct 27, 2022

Conversation

vaibhavgarg237
Copy link
Contributor

Describe the changes you have made in this PR

_In Recieve tab, on tapping Create Invoice while loading Amount, & Description fields should be disabled. _

Link this PR to an issue [optional]

Fixes #1659

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Add screenshots to make your changes easier to understand. You can also add a video here.

How has this been tested?

Go to receive tab, and mention Amount and Description. On clicking Create Invoice while loading input fields are disabled as it should be. Previously it can be edited while loading.

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@vaibhavgarg237 vaibhavgarg237 marked this pull request as ready for review October 25, 2022 18:02
@vaibhavgarg237 vaibhavgarg237 mentioned this pull request Oct 25, 2022
Closed
@github-actions
Copy link

github-actions bot commented Oct 25, 2022 •
edited
Loading

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

escapedcat
escapedcat approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@bumi
Copy link
Collaborator

bumi commented Oct 27, 2022

do we use fieldsets elsewhere?
I did not know that whole fieldsets can be disabled. TIL

can you fix the merge conflict?

@escapedcat
Copy link
Contributor

do we use fieldsets elsewhere?

Not yet, but that's the goal. They are semantic and helpful.

I did not know that whole fieldsets can be disabled. TIL

Same, learned it recently on twitter

@vaibhavgarg237
Copy link
Contributor Author

do we use fieldsets elsewhere? I did not know that whole fieldsets can be disabled. TIL

can you fix the merge conflict?

Here is the W3schools example

@vaibhavgarg237
Copy link
Contributor Author

do we use fieldsets elsewhere?

We are using fieldset disabled here

@vaibhavgarg237
Copy link
Contributor Author

can you fix the merge conflict?

Okay will do today

@bumi
Copy link
Collaborator

bumi commented Oct 27, 2022

thanks!

that we are consistent we should then use these fieldset in the future.
great!

@vaibhavgarg237
Copy link
Contributor Author

can you fix the merge conflict?

✅

@bumi bumi merged commit e109aa6 into getAlby:master Oct 27, 2022
@vaibhavgarg237 vaibhavgarg237 deleted the bug25 branch October 27, 2022 17:20
bumi added a commit that referenced this pull request Nov 1, 2022
@bumi
Merge branch 'feature/generic-webln-request' into feature/commando-co…
0e892a0 
…nnector

# By Lisa Oppermann (15) and others
# Via GitHub (22) and others
* feature/generic-webln-request: (58 commits)
  feat: add generic request method to webln
  fix: publisher link on AllowanceView
  Translated using Weblate (Italian)
  Update all development Yarn dependencies (2022-10-29)
  fix: align reject/close function params
  fix: navigate on send
  Update dayjs to version 1.11.6
  fix: disable input fields on Create Invoice #1659 (#1668)
  Update react-i18next to version 12.0.0
  Push buttons to bottom in Send and Receive Screens (#1672)
  refactor(lnurl): getDetails - avoid typecasting (#1545)
  style: prettier
  Translated using Weblate (Italian)
  Update tailwindcss to version 3.2.1
  style: prettier
  Translated using Weblate (Portuguese (Brazil))
  style: prettier
  Translated using Weblate (Italian)
  Translated using Weblate (Swedish)
  fix: remove response and additional error message
  ...

# Conflicts:
#	yarn.lock
bumi added a commit that referenced this pull request Nov 1, 2022
@bumi
Merge branch 'master' into feature/commando-connector
3651846 
# By Lisa Oppermann (15) and others
# Via GitHub (22) and others
* master: (57 commits)
  fix: publisher link on AllowanceView
  Translated using Weblate (Italian)
  Update all development Yarn dependencies (2022-10-29)
  fix: align reject/close function params
  fix: navigate on send
  Update dayjs to version 1.11.6
  fix: disable input fields on Create Invoice #1659 (#1668)
  Update react-i18next to version 12.0.0
  Push buttons to bottom in Send and Receive Screens (#1672)
  refactor(lnurl): getDetails - avoid typecasting (#1545)
  style: prettier
  Translated using Weblate (Italian)
  Update tailwindcss to version 3.2.1
  style: prettier
  Translated using Weblate (Portuguese (Brazil))
  style: prettier
  Translated using Weblate (Italian)
  Translated using Weblate (Swedish)
  fix: remove response and additional error message
  fix: use math floor everywhere
  ...

# Conflicts:
#	yarn.lock
bumi added a commit that referenced this pull request Nov 5, 2022
@bumi
Merge branch 'master' into feature/lnc-web
9cb1122 
# By Lisa Oppermann (15) and others
# Via GitHub (35) and escapedcat (1)
* master: (75 commits)
  fix: remove runcitadel sdk dependency (#1681)
  chore(deps): update puppeteer to v19
  revert(deps): puppeteer and fake-indexdb
  Update fake-indexeddb to version 4.0.0
  Update @types/chrome to version 0.0.200
  Update puppeteer to version 19.2.0
  fix: publisher link on AllowanceView
  Translated using Weblate (Italian)
  Update all development Yarn dependencies (2022-10-29)
  chore: remove showcases
  chore: remove topup app
  fix: align reject/close function params
  fix: navigate on send
  Update dayjs to version 1.11.6
  fix: disable input fields on Create Invoice #1659 (#1668)
  Update react-i18next to version 12.0.0
  Push buttons to bottom in Send and Receive Screens (#1672)
  refactor(lnurl): getDetails - avoid typecasting (#1545)
  style: prettier
  Translated using Weblate (Italian)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapedcat escapedcat escapedcat approved these changes

@im-adithya im-adithya Awaiting requested review from im-adithya

@reneaaron reneaaron Awaiting requested review from reneaaron

@lisabaut lisabaut Awaiting requested review from lisabaut

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] I shouldn't be able to edit fields like description after I click on Create invoice button
3 participants
@vaibhavgarg237 @bumi @escapedcat