fix: properly encode the LNURLp payerdata JSON #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this worked because the old axios version did that automatically (which was wrong)
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
escapedcat
reviewed
Nov 7, 2022
* master: (21 commits) chore: fix lodash types and reduce package size chore: remove storybook github action chore: remove storybook stories chore: remove storybook config docs: adjust storybook info chore: remove storybook Translated using Weblate (Italian) fix: handle dexie in jest Update react-router-dom to version 6.4.3 Update i18next-browser-languagedetector to version 7.0.1 Update react-toastify to version 9.1.1 fix: yarn lock fix: use transformIgnorePatterns for dexie chore: remove unused runcitadel sdk prettier i18nConfig.ts feat(i18n): activate italian feat: handle organization pages fix: highlight menu icon dots fix: tipping in medium fix: fetch from description element ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this worked because the old axios version did that automatically (which was wrong)
Describe the changes you have made in this PR
I think the updated axios version #1702 behaves differently.
We had passed in the query params here wrong and did not encode the JSON manually.
Thus the payerdata was sent wrong to the server
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)How has this been tested?
send a payment to a LN address that supports payerdata.