Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow of website title #1809

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

Long website names / titles currently allow the publisher card to grow indefinitely: (and shift important UI elements out of the view at the bottom)

image

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

image

@reneaaron reneaaron marked this pull request as ready for review December 1, 2022 12:53
@reneaaron reneaaron requested a review from escapedcat December 1, 2022 12:53
Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@escapedcat escapedcat requested a review from im-adithya December 1, 2022 12:56
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

@escapedcat escapedcat merged commit 7dbeaa0 into master Dec 1, 2022
@escapedcat escapedcat deleted the fix/publisher-card-overflow branch December 1, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants