-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: form el for ConfirmorCancel #1617 #1816
Conversation
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. Don't forget: keep earning sats! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
You are a machine! 🚀🚀 |
@vaibhavgarg237 please remove the forms where we do not have any inputs. Talked to @im-adithya and we think this is confusing. But we should always use forms (and formfields if useful) if we actually have input-fields. Thanks for your contribution! |
415c94d
to
e53c1c5
Compare
Alright, I have updated the required changes. |
Describe the changes you have made in this PR
Wrapped all the ConfirmorCancel components forms with forms and handling submit operation via onSubmit instead of onClick
Link this PR to an issue [optional]
Fixes #1617
Type of change
(Remove other not matching type)
fix
: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
Refactored code
Checklist