Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: form el for ConfirmorCancel #1617 #1816

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

vaibhavgarg237
Copy link
Contributor

@vaibhavgarg237 vaibhavgarg237 commented Dec 4, 2022

Describe the changes you have made in this PR

Wrapped all the ConfirmorCancel components forms with forms and handling submit operation via onSubmit instead of onClick

Link this PR to an issue [optional]

Fixes #1617

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Refactored code

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

src/app/screens/ConfirmSignMessage/index.tsx Outdated Show resolved Hide resolved
src/app/screens/Enable/index.tsx Outdated Show resolved Hide resolved
src/app/screens/LNURLAuth/index.tsx Outdated Show resolved Hide resolved
src/app/screens/LNURLChannel/index.tsx Outdated Show resolved Hide resolved
src/app/screens/LNURLWithdraw/index.tsx Outdated Show resolved Hide resolved
@escapedcat escapedcat requested a review from im-adithya December 5, 2022 15:07
escapedcat
escapedcat previously approved these changes Dec 5, 2022
Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@vaibhavgarg237
Copy link
Contributor Author

ack

You are a machine! 🚀🚀

@escapedcat
Copy link
Contributor

@vaibhavgarg237 please remove the forms where we do not have any inputs. Talked to @im-adithya and we think this is confusing. But we should always use forms (and formfields if useful) if we actually have input-fields.

Thanks for your contribution!

@escapedcat escapedcat dismissed their stale review December 5, 2022 15:53

See last comment

@vaibhavgarg237
Copy link
Contributor Author

@vaibhavgarg237 please remove the forms where we do not have any inputs. Talked to @im-adithya and we think this is confusing. But we should always use forms (and formfields if useful) if we actually have input-fields.

Thanks for your contribution!

Alright, I have updated the required changes.

@escapedcat escapedcat merged commit 72c55d0 into getAlby:master Dec 8, 2022
@vaibhavgarg237 vaibhavgarg237 deleted the submitConfirm branch December 16, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants