fix: add favicon to extension pages (firefox) #1857
Conversation
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
|
@im-adithya looks good. should we add the same to |
Right, I don't think so.
This is being prompted if you interact with a website i.e. "connect", "do a payment", etc. |
| @@ -4,6 +4,7 @@ | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
| <link rel="icon" type="image/png" href="assets/icons/alby_icon_yellow_32x32.png"> | |||
There was a problem hiding this comment.
@escapedcat this path might be relevant for v3. - there was some change in the paths, wasn't it?
There was a problem hiding this comment.
It should not matter for the metatags but will check
Describe the changes you have made in this PR
Favicons in extension pages
Link this PR to an issue [optional]
--
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Screenshots of the changes [optional]
How has this been tested?
Manually
Checklist