Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/i18n zh cn #1922

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Feat/i18n zh cn #1922

merged 2 commits into from
Jan 6, 2023

Conversation

escapedcat
Copy link
Contributor

Chinese is at 84%: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/
Other languages we already support have a similar percentage.
像差不多吧

  • switched 聪 to sat/sats, we shouldn't translate these

@escapedcat
Copy link
Contributor Author

@qqqzhch @ra5pvt1n you wanna give this a try? 谢!

@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: Moritz (who recently dropped 1000 sats):

Merry Christmas to the Alby team

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@ra5pvt1n
Copy link
Contributor

ra5pvt1n commented Jan 5, 2023

Will check/update in the coming days. It's been a hectic couple of weeks.

My opinion regarding sats - since Satoshi is a Japanses name it can be transliterated into Han characters. Not everyone can read Latin alphabets or understand basic phonology and we should not raise the barrier of entry for potential users.

But indeed some sort of translation standard would be helpful to keep different projects consistent. Do you know of any initiatives working on standardising translations?

@bumi
Copy link
Collaborator

bumi commented Jan 6, 2023

wow that's amazing! maybe we can reach out on twitter and other communities about standardising translations? and what's the current preferred way?

@bumi
Copy link
Collaborator

bumi commented Jan 6, 2023

I guess I can merge it for now and we update the words once decided?

@bumi bumi merged commit 1b5bd90 into master Jan 6, 2023
@bumi bumi deleted the feat/i18n_zh-CN branch January 6, 2023 00:42
@ra5pvt1n
Copy link
Contributor

ra5pvt1n commented Jan 7, 2023

Yes do merge.

I don't have a twitter account haha, and I don't know if there's a large Chinese speaking community there (perhaps from Hong Kong). Maybe @escapedcat @qqqzhch are more informed about this topic - where is the community most active?

The current preferred way for me is using the character 聪 for sats (also in RoboSats translations).

@qqqzhch
Copy link
Contributor

qqqzhch commented Jan 10, 2023

@escapedcat @ra5pvt1n
OK, there is a problem with the front-end time of my environment. I'll take a look at this after I fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants