feat: include account ID in permissions

[im-adithya]

Describe the changes you have made in this PR

Adds accountId to the DbPermission fields to link permissions to accounts. (Doesn't include a migration; we handle the permissions without an accountId separately everywhere).

Link this PR to an issue [optional]

Fixes #1953

Type of change

(Remove other not matching type)

• feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

How has this been tested?

Tested manually at various websites.

Checklist

• My code follows the style guidelines of this project and performed a self-review of my own code
• New and existing tests pass locally with my changes
• I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

[github-actions]

🚀 Thanks for the pull request!

Here are the current build files for testing:

• chrome.zip.zip
• firefox.xpi.zip
• opera.crx.zip

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

---

This build is brought to you by: channel.ninja (who recently dropped 1000 sats):

---

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

[reneaaron]

Successfully tested 👌 the migration also worked as expected! 👍

[reneaaron]

Just did a final round of testing and noticed one thing that I think we should fix. Steps to reproduce:

I have 2 accounts (account A, account B)

• Account A: Go to a site and give permissions to read public key
• Go to the websites, select the website from step 1 and click on edit. You will see the permissions correctly:
  
• Close the permission popup (but stay on this site), switch to account B
• Edit the permissions with account B

The edit dialogue now still shows the permissions from account A. (reloading fixes the problem)

@im-adithya Can we somehow fix that?

That being said, I think we really need to move the permissions somewhere else in another iteration, they don't fit into this "edit allowance" window very well. Also the allowance is now extension wide, while the permissions are not. (which I think is quite hard to understand)

[reneaaron]

Tested again today, left some feedback and merged master.

Let's see if we can somehow fix the bug when switching accounts and get this merged! 🚀

[lujakob]

Tested again today, left some feedback and merged master.

Let's see if we can somehow fix the bug when switching accounts and get this merged! 🚀

I tested a bit. The bug is in AllowanceMenu line 77 !permissions && fetchPermissions(); - the !permissions condition needs to be removed and permissions from the deps. But better double check the re-rendering performance.

https://github.com/getAlby/lightning-browser-extension/pull/2002/files#diff-1b329da99ce24a934532ca1ee401d135a5d5917619b62db9711da859ce47f987R77

[reneaaron]

Thanks for the updates @im-adithya! 🚀

tACK