feat: add channel.ninja to discover websites #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
channelninja
force-pushed
the
feat/add-channelninja-website
branch
from
6e810c5 to
2f55d4a
Compare
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
|
Tested the build files. Looks good to me |
bumi
reviewed
Jan 28, 2023
|
thanks! we avoid loading external content so I moved the logo to our domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
I added https://channel.ninja to the discover websites.
For the logo I used my self hosted logo, this needs to be changed out for one hosted on cdn.getalby-assets.com.
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)How has this been tested?
Adding one object to the websites array shouldn't break anything. so no tests for this 🤞
Checklist