Compress discover page images #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2018 Compressed images will be uploaded to DigitalOcean (DO) bucket. changed file extension from SVG to PNG because those were: a. fake SVGs that only contained embedded PNGs b. real SVG files I found on the net did not fit square formatting or had weird viewbox/size parameters so I couldn't get them to fit into our page without editing the SVGs in Adobe Illustrator. + PNGs are scaled to 256x256 (where the original PNG was large enough, one was slightly smaller and I kept its original size), which is more than enough for the 56x56 CSS pixel elements we have on the discover page.
jankoegel
commented
Feb 1, 2023
| @@ -5,19 +5,19 @@ | |||
| { | |||
| "title": "LNMarkets", | |||
| "subtitle": "Instant Bitcoin derivatives trading", | |||
| "logo": "https://cdn.getalby-assets.com/alby-extension-website-screen/lnmarketes.svg", | |||
| "logo": "https://cdn.getalby-assets.com/alby-extension-website-screen/lnmarkets.png", | |||
There was a problem hiding this comment.
fixed typo in file name
This should be the same bucket under a different name / domain.
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
Nostr clients: add Hamstr, ABC-sort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
adds Hamstr to list of Nostr clients.
reduces total file size from
2.4MBto179kB.Compressed images will be uploaded to DigitalOcean (DO) bucket. File extension were changed from
.svgto.pngbecause those were either:a. fake SVGs that only contained embedded PNGs (I extracted the PNG content, so it's a real PNG now - no worries).
b. real SVG files I found on the net did not fit square formatting or had weird viewbox/size parameters so I couldn't get them to fit into our page without editing the SVGs in Adobe Illustrator -> converted to PNG with photoshop
PNGs were scaled to 256x256px where the original PNG was large enough. One original image was slightly smaller and I kept its original size. 256px is more than enough for the 56x56 CSS-pixel elements we have on the discover page.
📥 DOWNLOAD compressed-icons.zip
TODOs
Screenshots