Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pt_br language bug in permissions #2080

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

manavdesai27
Copy link
Contributor

Describe the changes you have made in this PR

Fixed language error in permissions menu while using pt_br

Link this PR to an issue [optional]

Fixes #2062

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

image

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@manavdesai27
Copy link
Contributor Author

@im-adithya Could you review? Thanks!

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@manavdesai27
Copy link
Contributor Author

@escapedcat Could you review please?

Copy link
Contributor

@escapedcat escapedcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manavdesai27 , sorry for the hassle!

@escapedcat escapedcat merged commit c96a4c2 into getAlby:master Feb 8, 2023
@manavdesai27 manavdesai27 deleted the fix/permissions_language branch February 8, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some texts already translated to PT-BR a long time ago still appear in English on Alby UI
2 participants