Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include account in connector #2135

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix: include account in connector #2135

merged 2 commits into from
Mar 6, 2023

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

The connector needs to write to the state: https://github.com/getAlby/lightning-browser-extension/blob/master/src/extension/background-script/connectors/lnc.ts#L136-L143

And for that it loads the current account, but during account switching this might already be another account.

=> we should not only pass in the config to the connectors but the whole account, that the connector knows its ID and can use that to save to storage.

So we pass the whole account to the connector so that the id can be accessed from within.

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

github-actions bot commented Feb 22, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@bumi bumi merged commit dd16e3b into master Mar 6, 2023
@bumi bumi deleted the task-connector-account branch March 6, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants