Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change edit allowance text to edit preferences #2232

Merged
merged 5 commits into from
May 2, 2023

Conversation

manavdesai27
Copy link
Contributor

Describe the changes you have made in this PR

Changed Edit Allowance to Edit Preferences as stated in #2093

Link this PR to an issue [optional]

Fixes #2093

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

image

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@manavdesai27
Copy link
Contributor Author

@escapedcat Kindly review this PR. Thanks much!

@@ -178,14 +178,14 @@ function AllowanceMenu({ allowance, onEdit, onDelete }: Props) {
closeTimeoutMS={200}
isOpen={modalIsOpen}
onRequestClose={closeModal}
contentLabel={t("edit_allowance.screen_reader")}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sure, but I don't think we need to change the i18n string here. We can just adjust the translation. Technically it's still an allowance, we just try to make it easier to understand for the user.
wdyt @im-adithya ?

@escapedcat escapedcat requested a review from im-adithya March 21, 2023 10:31
@im-adithya im-adithya merged commit a408a48 into getAlby:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The text title Edit Allowance looks wrong because there are others options.
3 participants